Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guidance on icon colors for the ActionMenu items #647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmwinters
Copy link

There's some ambiguity about whether or not we should recommend different colors for leading icons in the ActionMenu.

This PR updates the guidance to recommend against using colored icons for anything other than destructive actions.

CleanShot 2023-10-24 at 16 51 30@2x

@Lobesitdoll
Copy link

I Agree , keep it simple .

@maximedegreve
Copy link
Contributor

maximedegreve commented Oct 30, 2023

Thank you for adding this @cmwinters.

This looks good but I have a few improvements we could make.

  • Could you make the dropdown less wide since the menu should never go this wide for the content it currently holds. (Example).
  • Could we find a more realistic example? Actions currently don't have the ability to be forked, sponsored or starred. If Actions refers a generic list of actions and not the product then a 3 dot or cog icon button would make more sense.
  • We also tend to group edit actions. Therefore adding a separator before the delete action would make sense here. (example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants