Import NavList from main bundle

[broccolinisoup]

We are removing NavList from the drafts bundle in the next major release in this PR and because we are removing it, CI fails on the PR. (https://github.com/primer/react/actions/runs/5582895864/jobs/10202654279?pr=3260)

I update the path to import it from the main bundle.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6fc65c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[joshblack]

Seeing this error from CI:

warning "export 'NavList' was not found in '@primer/react'

Does the dependency need to be updated here: https://github.com/primer/doctocat/blob/main/theme/package.json#L37 potentially to the version which includes it? Or is there some other shenanigans going on here with Gatsby 😅

[mperrotti]

@broccolinisoup - it looks like Doctocat is on a really old version of @primer/react. NavList should be available in the main bundle once we update 🙂

[broccolinisoup]

@mperrotti @joshblack Sorry, this is my ignorance 😬 I didn't even think of checking back - I just assumed that will work. Let me try upgrading primer/react - I know @josepmartins had some issues with upgrading to the latest so it might not be very straightforward

[josepmartins]

I know @josepmartins had some issues with upgrading to the latest so it might not be very straightforward

I've tried on this PR #601 to use the latest Underlinenav component, but I finally gave up and used the deprecated one. Couldn't build locally or pass the build actions :(

[mperrotti]

@josepmartins - the deprecated one is going away when we release v36 later this quarter 🙁

Let me know if you want to pair on the upgrade. I suspect it has something to do with mismatched versions of React.

[mperrotti]

Should we add a "blocked" label to this? We're blocked until we can upgrade Gatsby and React.

cc @josepmartins @broccolinisoup

[broccolinisoup]

@mperrotti That sounds good to me! I added the label! Although this PR is blocked itself but it is not blocking v36 PR I mentioned in the description anymore - we will keep the NavList in the draft bundle until we figure this out.

[github-actions]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

[github-actions]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

[github-actions]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.