-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit-heading
rule
#66
Conversation
🦋 Changeset detectedLatest commit: 4560876 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I can review more carefully tomorrow, but do you think this is considered an accessibility rule, and would we want to include this rule in the accessibility scorecard? If so, we should prefix the name with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one open question about prefixing this lint rule with a11y-
so we can identify it as an accessibility-related rule more easily and eventualy track it in our scorecard. (We're still figuring out the rollout system around that in https://github.com/github/accessibility/issues/3868).
Aside from that, I have no concerns. This is awesome! 🎉
@khiga8 Yup I can definitely add that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this! Thanks for a new shiny rule 🤩 Only thing I would say is that we should add this rule to the README.md.
Adds
explicit-heading
rule. This rule disallows the following:Heading
without providing a heading level viaas
, (e.g.<Heading>
)as
for any element that is not a heading (h1
-h6
)Additional context: #57.