You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/.github/CONTRIBUTING.md refers to /octicons/svg and mentions being "GitHub's icon font," even though fonts were deprecated in #108.
Also, license in package.json includes "OFL". Not sure if this still applies or if it needs to remain due to there being fonts in previous versions.
I don't know if the SVGs are still generated by an automated process. From what I can tell, /lib/octicons-master.sketch is the original file that is used to generate all /lib/svg/*.svg (running Linux and have no access to Sketch).
Do you not accept pull requests or issues relating to changes in icons? If someone did want to contribute by adding an icon or changing an existing one, would you accept a pull request involving just an SVG, or would you require changes in Sketch? If you accept changes to SVGs, do you require the <?xml version="1.0" encoding="UTF-8"?> and all attributes on <svg>?
The text was updated successfully, but these errors were encountered:
/.github/CONTRIBUTING.md
refers to/octicons/svg
and mentions being "GitHub's icon font," even though fonts were deprecated in #108.Also, license in
package.json
includes "OFL". Not sure if this still applies or if it needs to remain due to there being fonts in previous versions.I don't know if the SVGs are still generated by an automated process. From what I can tell,
/lib/octicons-master.sketch
is the original file that is used to generate all/lib/svg/*.svg
(running Linux and have no access to Sketch).Do you not accept pull requests or issues relating to changes in icons? If someone did want to contribute by adding an icon or changing an existing one, would you accept a pull request involving just an SVG, or would you require changes in Sketch? If you accept changes to SVGs, do you require the
<?xml version="1.0" encoding="UTF-8"?>
and all attributes on<svg>
?The text was updated successfully, but these errors were encountered: