Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(octicons_react): add support for ESM import #1008

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

joshblack
Copy link
Member

Closes #1006

Update how we expose the ESM import for @primer/octicons-react by adding an mjs extension for the icon entrypoint and an mts extension for the types import.

One way to test that the imports and types are resolving correctly is to build the package and run npx publint .. The results for this package are currently visible at: https://publint.dev/@primer/octicons-react. With this change, there should be no errors, warnings, or suggestions.

@joshblack joshblack requested a review from a team as a code owner March 4, 2024 20:04
@joshblack joshblack requested a review from edokoa March 4, 2024 20:04
Copy link

changeset-bot bot commented Mar 4, 2024

🦋 Changeset detected

Latest commit: 1e89330

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack requested a review from a team as a code owner March 13, 2024 16:12
@joshblack joshblack merged commit c5786ff into main Mar 13, 2024
10 checks passed
@joshblack joshblack deleted the feat/add-support-for-esm branch March 13, 2024 17:20
@primer primer bot mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] @primer/octicons-react esm is incorrectly exported
2 participants