Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(octicons_react): remove build from npm package files #1009

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Mar 4, 2024

Closes #998

This removes build from the list of files for the npm package. These files are not accessible since we currently use the exports field so removing this should be compatible within semver (but let me know if not!)

@joshblack joshblack requested a review from a team as a code owner March 4, 2024 20:08
Copy link

changeset-bot bot commented Mar 4, 2024

⚠️ No Changeset found

Latest commit: ca27342

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are not accessible since we currently use the exports field so removing this should be compatible within semver (but let me know if not!)

That makes sense to me!

@joshblack joshblack requested a review from a team as a code owner March 13, 2024 15:25
@joshblack joshblack requested a review from pksjce March 13, 2024 15:25
@joshblack joshblack merged commit dc333cc into main Mar 13, 2024
10 checks passed
@joshblack joshblack deleted the fix/remove-build-from-files branch March 13, 2024 15:28
@fregante
Copy link
Contributor

Hmm why not just merge my PRs?

@camertron
Copy link
Contributor

@fregante I'm not 100% sure in this case, but we usually do this because certain actions won't run from forks.

@joshblack
Copy link
Member Author

I'm sorry about that @fregante, that's totally on me. I'd be happy to revert this one and merge in yours if you would be interested!

@fregante
Copy link
Contributor

No problem to leave as is, I was just wondering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] @primer/octicons-react includes raw SVG files, but are inaccessible
4 participants