-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(octicons_react): remove build from npm package files #1009
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files are not accessible since we currently use the exports field so removing this should be compatible within semver (but let me know if not!)
That makes sense to me!
Hmm why not just merge my PRs? |
@fregante I'm not 100% sure in this case, but we usually do this because certain actions won't run from forks. |
I'm sorry about that @fregante, that's totally on me. I'd be happy to revert this one and merge in yours if you would be interested! |
No problem to leave as is, I was just wondering |
Closes #998
This removes
build
from the list offiles
for the npm package. These files are not accessible since we currently use theexports
field so removing this should be compatible within semver (but let me know if not!)