Add picosvg to optimization step #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a40ba19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eliperkins
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This should help remove `fill-rule="evenodd"` from SVGs, improving where they can be rendered.
eliperkins
force-pushed
the
ep/picosvg
branch
from
f8caa19 to
5e4813a
Compare
Merged
lunny
pushed a commit
to go-gitea/gitea
that referenced
this pull request
Jan 21, 2023
- Update all JS dependencies - Add new eslint rules - Rebuild SVGs - Tested citation and build SVG changes are because of primer/octicons#883. Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
A redux of #880 from
primer/octicons, rather than my fork (eliperkins/octicons).This adds in
picosvgto the "Optimize SVGs" workflow, removingfill-rule="evenodd"from all SVGs.Since
picosvgis meant to work on a single file at a time, I used a bash loop to iterate through all files iniconsbefore writing them back out, in-place.cc @gavinmn @colebemis