Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit upload, download. Add move to icons #904

Merged
merged 7 commits into from
Jan 27, 2023
Merged

Conversation

CameronFoxly
Copy link
Contributor

@CameronFoxly CameronFoxly commented Jan 25, 2023

This PR Adds updates the upload and download icons with brackets to differentiate these from the new move-to-top and move-to-bottom additions. Also adds move-to-start and move-to-end.

New upload and download:
Screen Shot 2023-01-25 at 11 23 04 AM

move-to-top, move-to-bottom, move-to-start, and move-to-end:
Screen Shot 2023-01-25 at 11 24 50 AM

This is in reference to this issue

CameronFoxly and others added 3 commits January 25, 2023 11:18
…move-to-top-16.svg, move-to-bottom-16.svg, move-to-bottom-24.svg, move-to-top-24.svg, move-to-start-24.svg, move-to-end-24.svg, move-to-end-16.svg, move-to-start-16.svg
Added `move-to-start`, `move-to-end`, `move-to-top`, `move-to-bottom`
@CameronFoxly CameronFoxly requested a review from a team as a code owner January 25, 2023 19:38
@CameronFoxly CameronFoxly requested a review from gavinmn January 25, 2023 19:38
@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023

🦋 Changeset detected

Latest commit: 70e48b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CameronFoxly CameronFoxly temporarily deployed to github-pages January 25, 2023 19:45 — with GitHub Actions Inactive
@CameronFoxly CameronFoxly temporarily deployed to github-pages January 25, 2023 19:58 — with GitHub Actions Inactive
@gavinmn gavinmn changed the title Upload download move tos Edit upload, download. Add move to icons Jan 25, 2023
Co-authored-by: Gavin Nelson <gavin@nelson.co>
@gavinmn gavinmn self-requested a review January 27, 2023 17:24
@CameronFoxly CameronFoxly temporarily deployed to github-pages January 27, 2023 17:25 — with GitHub Actions Inactive
@gavinmn gavinmn merged commit ad0eb56 into main Jan 27, 2023
@gavinmn gavinmn deleted the upload-download-move-tos branch January 27, 2023 17:49
@primer-css primer-css mentioned this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants