Skip to content

Commit

Permalink
Update ADR-005 with decision rationale and questions
Browse files Browse the repository at this point in the history
  • Loading branch information
lukasoppermann authored Dec 9, 2024
1 parent 016b1e3 commit ac6e1ee
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions contributor-docs/adrs/adr-005-token-prefix.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,19 @@ Currently primitives have no prefix, which means once converted to css they can

To solve this we could add a prefix like `primer` or `product` to our tokens, resulting in css variables like `--primer-fgColor-default`.

## Decision
To decide this, the following questions need to be answered:

1. Do we think that this is a legit problem that is serious enough to invest somewhat significant resources into?
-> No, because we did not get any issues or other reports of complications with token naming collisions. We also have not had any reports of people running into issues where they have a hard time differentiating between their own tokens and primitives.

The following decisions need ot be made:
~2. If yes, what is an appropriate prefix?~

1. Do we think that this is a legit problem that is serious enough to invest somewhat significant resources into?
2. If yes, what is an appropriate prefix?
3. If no, do we need some kind of guidance in primer.style, or are we good without it?
-> Without specific issues there is no specific need for guidance.

## Decision

We will not add a prefix to our primitives at this time. The main reason being that we have no reports of issues

### Impact

Expand Down

0 comments on commit ac6e1ee

Please sign in to comment.