Adding pascalCase transform to be used by brand #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 94327e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Design Token DiffNo design tokens changed |
9 tasks
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
rezrah
reviewed
Aug 29, 2024
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@primer/primitives': minor | |||
There was a problem hiding this comment.
Just curious how you determine the version. Why minor vs patch?
There was a problem hiding this comment.
@rezrah I figure we are adding a feature here, so minor is more appropriate. Let me know if you have some good guidelines as to when to choose which version.
There was a problem hiding this comment.
Yeah that makes sense. Thanks.
rezrah
reviewed
Aug 29, 2024
rezrah
reviewed
Aug 29, 2024
rezrah
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Left some minor, non-blocking feedback.
Thanks for doing this @lukasoppermann 🙏
lukasoppermann
changed the title
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pascalCase transformer