Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figma mode improvements #1093

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Figma mode improvements #1093

merged 2 commits into from
Nov 29, 2024

Conversation

lukasoppermann
Copy link
Contributor

Summary

All changes are for Figma export:

  • rely on auto-added mode for design tokens
  • rename property from mode to modeOverride to signal that this is not supposed to be used for every token, only if there is a need to override
  • remove mode property from token definitions

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann lukasoppermann self-assigned this Nov 26, 2024
@lukasoppermann lukasoppermann requested review from a team as code owners November 26, 2024 09:32
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b8d2054

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Nov 26, 2024
@primer primer deleted a comment from github-actions bot Nov 28, 2024
@lukasoppermann lukasoppermann force-pushed the figma-mode-improvement branch 2 times, most recently from 5d0edb0 to 335aa67 Compare November 29, 2024 11:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Design Token Diff (StyleLint)

The message is too long to be displayed here. For more details, please check the job summary.

@lukasoppermann lukasoppermann merged commit e00e02e into main Nov 29, 2024
27 checks passed
@lukasoppermann lukasoppermann deleted the figma-mode-improvement branch November 29, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/css-reviewers

Assignees

@lukasoppermann lukasoppermann

Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann