Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADR] moving and updating ADR concerning design token structure #1108

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[ADR] moving and updating ADR concerning design token structure #1108

merged 3 commits into from
Dec 10, 2024

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Dec 6, 2024 •
edited
Loading

Summary

This PR moves this ADR from github/primer to primer/primitives.

Some updates are needed to reflect the current state of things.

Todo

  • Update "Valid token types and values" section

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Dec 6, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bff4e7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 6, 2024 10:00 Inactive
@lukasoppermann lukasoppermann force-pushed the adr-design-token-structure branch from 67103ef to 804e0c4 Compare December 6, 2024 10:38
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 6, 2024 10:41 Inactive
@lukasoppermann lukasoppermann force-pushed the adr-design-token-structure branch from 804e0c4 to 3db3c9a Compare December 10, 2024 10:02
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 10, 2024 10:04 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 10, 2024 10:53 Inactive
@lukasoppermann lukasoppermann marked this pull request as ready for review December 10, 2024 10:57
@lukasoppermann lukasoppermann requested review from a team as code owners December 10, 2024 10:57
@lukasoppermann lukasoppermann force-pushed the adr-design-token-structure branch from 139e6b7 to bff4e7c Compare December 10, 2024 10:58
@lukasoppermann lukasoppermann self-assigned this Dec 10, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 10, 2024 11:00 Inactive
@lukasoppermann lukasoppermann merged commit e4f93c9 into main Dec 10, 2024
27 checks passed
@lukasoppermann lukasoppermann deleted the adr-design-token-structure branch December 10, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/css-reviewers

Assignees

@lukasoppermann lukasoppermann

Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann