Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): remove optional deps #1123

Merged
merged 5 commits into from
Dec 13, 2024
Merged

chore(deps): remove optional deps #1123

merged 5 commits into from
Dec 13, 2024

Conversation

joshblack
Copy link
Member

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8fb2ae8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 12, 2024 23:23 Inactive
lukasoppermann
lukasoppermann approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@lukasoppermann lukasoppermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was needed because we were getting bugs. Maybe upgrading to eslint v9 resolved them.

@lukasoppermann lukasoppermann marked this pull request as ready for review December 13, 2024 15:27
@lukasoppermann lukasoppermann requested review from a team as code owners December 13, 2024 15:27
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 13, 2024 15:30 Inactive
@lukasoppermann lukasoppermann added skip changeset Apply to PRs that should not result in a version bump. update snapshots Update visual regression test snapshots labels Dec 13, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Dec 13, 2024
@primer primer bot temporarily deployed to github-pages December 13, 2024 16:19 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 13, 2024 16:19 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 13, 2024 16:26 Inactive
@langermank langermank added the update snapshots Update visual regression test snapshots label Dec 13, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Dec 13, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 13, 2024 17:12 Inactive
@langermank langermank merged commit b91eebb into main Dec 13, 2024
27 checks passed
@langermank langermank deleted the chore/remove-optional-deps branch December 13, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasoppermann lukasoppermann lukasoppermann approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @lukasoppermann @langermank