Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sort by name to css #1127

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add sort by name to css #1127

merged 1 commit into from
Dec 13, 2024

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Dec 13, 2024 •
edited
Loading

Summary

This sorts all css tokens by name so that in the css output the tokens are in alphabetical order. This will make it easier to maintain, as our diffs will not have position changes anymore.

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Dec 13, 2024
@lukasoppermann lukasoppermann self-assigned this Dec 13, 2024
@lukasoppermann lukasoppermann requested review from a team as code owners December 13, 2024 13:12
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: 236c2fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Design Token Diff (CSS)

The message is too long to be displayed here. For more details, please check the job summary.

@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 13, 2024 13:14 Inactive
@lukasoppermann lukasoppermann merged commit d4c7ea4 into main Dec 13, 2024
28 of 31 checks passed
@lukasoppermann lukasoppermann deleted the sortTokensByNameCss branch December 13, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/css-reviewers

Assignees

@lukasoppermann lukasoppermann

Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann