Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move diffBlob tritanopia into diffBlob component file #1139

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

lukasoppermann
Copy link
Contributor

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Dec 18, 2024
@lukasoppermann lukasoppermann requested review from a team as code owners December 18, 2024 20:35
Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 8b45706

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasoppermann lukasoppermann changed the title diffB;ob tritanopia move diffBlob tritanopia into diffBlob component file Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Design Token Diff (StyleLint)

The message is too long to be displayed here. For more details, please check the job summary.

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Design Token Diff (Figma)

/figma/themes/dark-tritanopia.json

+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark-tritanopia.json	2024-12-18 20:49:22.490614937 +0000
@@ -2113,6 +2113,23 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "diffBlob/additionWord/bgColor",
+    "value": {
+      "r": 0.2196078431372549,
+      "g": 0.5450980392156862,
+      "b": 0.9921568627450981,
+      "a": 0.4
+    },
+    "type": "COLOR",
+    "alpha": 0.4,
+    "refId": "mode/diffBlob/additionWord/bgColor",
+    "reference": "base/color/dark/base/color/blue/4",
+    "collection": "mode",
+    "mode": "dark tritanopia",
+    "group": "component",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "diffBlob/additionNum/fgColor",
   "value": {
     "r": 0.9411764705882353,
@@ -2129,6 +2146,23 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "diffBlob/additionNum/bgColor",
+    "value": {
+      "r": 0.34509803921568627,
+      "g": 0.6509803921568628,
+      "b": 1,
+      "a": 0.3
+    },
+    "type": "COLOR",
+    "alpha": 0.3,
+    "refId": "mode/diffBlob/additionNum/bgColor",
+    "reference": "base/color/dark/base/color/blue/3",
+    "collection": "mode",
+    "mode": "dark tritanopia",
+    "group": "component",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "diffBlob/deletionLine/fgColor",
   "value": {
     "r": 0.9411764705882353,
@@ -2227,6 +2261,22 @@
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "diffBlob/hunkLine/bgColor",
+    "value": {
+      "r": 0.12941176470588237,
+      "g": 0.1568627450980392,
+      "b": 0.18823529411764706,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/diffBlob/hunkLine/bgColor",
+    "reference": "base/color/dark/base/color/neutral/3",
+    "collection": "mode",
+    "mode": "dark tritanopia",
+    "group": "component",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "diffBlob/hunkLine/fgColor",
   "value": {
     "r": 0.5686274509803921,
@@ -2275,6 +2325,38 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "diffBlob/hunkNum/bgColor/rest",
+    "value": {
+      "r": 0.1843137254901961,
+      "g": 0.21568627450980393,
+      "b": 0.25882352941176473,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/diffBlob/hunkNum/bgColor/rest",
+    "reference": "base/color/dark/base/color/neutral/6",
+    "collection": "mode",
+    "mode": "dark tritanopia",
+    "group": "component",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
+    "name": "diffBlob/hunkNum/bgColor/hover",
+    "value": {
+      "r": 0.396078431372549,
+      "g": 0.4235294117647059,
+      "b": 0.4627450980392157,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/diffBlob/hunkNum/bgColor/hover",
+    "reference": "base/color/dark/base/color/neutral/8",
+    "collection": "mode",
+    "mode": "dark tritanopia",
+    "group": "component",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "diffBlob/emptyNum/bgColor",
   "value": {
     "r": 0.08235294117647059,

/figma/themes/light-tritanopia.json

+++ /home/runner/work/primitives/primitives/dist/figma/themes/light-tritanopia.json	2024-12-18 20:49:20.660622912 +0000
@@ -2061,6 +2061,22 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "diffBlob/additionWord/bgColor",
+    "value": {
+      "r": 0.7137254901960784,
+      "g": 0.8901960784313725,
+      "b": 1,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/diffBlob/additionWord/bgColor",
+    "reference": "base/color/light/base/color/blue/1",
+    "collection": "mode",
+    "mode": "light tritanopia",
+    "group": "component",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "diffBlob/additionNum/fgColor",
   "value": {
     "r": 0.12156862745098039,
@@ -2077,6 +2093,22 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "diffBlob/additionNum/bgColor",
+    "value": {
+      "r": 0.7137254901960784,
+      "g": 0.8901960784313725,
+      "b": 1,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/diffBlob/additionNum/bgColor",
+    "reference": "base/color/light/base/color/blue/1",
+    "collection": "mode",
+    "mode": "light tritanopia",
+    "group": "component",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "diffBlob/deletionLine/fgColor",
   "value": {
     "r": 0.12156862745098039,
@@ -2125,6 +2157,22 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "diffBlob/deletionWord/bgColor",
+    "value": {
+      "r": 1,
+      "g": 0.807843137254902,
+      "b": 0.796078431372549,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/diffBlob/deletionWord/bgColor",
+    "reference": "base/color/light/base/color/red/1",
+    "collection": "mode",
+    "mode": "light tritanopia",
+    "group": "component",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "diffBlob/deletionNum/fgColor",
   "value": {
     "r": 0.12156862745098039,
@@ -2141,6 +2189,22 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "diffBlob/deletionNum/bgColor",
+    "value": {
+      "r": 1,
+      "g": 0.807843137254902,
+      "b": 0.796078431372549,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/diffBlob/deletionNum/bgColor",
+    "reference": "base/color/light/base/color/red/1",
+    "collection": "mode",
+    "mode": "light tritanopia",
+    "group": "component",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "diffBlob/hunkLine/bgColor",
   "value": {
     "r": 0.9647058823529412,
@@ -2185,6 +2249,22 @@
   "reference": "mode/fgColor/default",
   "collection": "mode",
   "mode": "light tritanopia",
+    "group": "component",
+    "scopes": ["TEXT_FILL", "SHAPE_FILL"]
+  },
+  {
+    "name": "diffBlob/hunkNum/fgColor/hover",
+    "value": {
+      "r": 0.12156862745098039,
+      "g": 0.13725490196078433,
+      "b": 0.1568627450980392,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/diffBlob/hunkNum/fgColor/hover",
+    "reference": "mode/fgColor/default",
+    "collection": "mode",
+    "mode": "light tritanopia",
   "group": "component",
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },

@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 18, 2024 20:38 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 18, 2024 20:50 Inactive
@lukasoppermann lukasoppermann merged commit 1c0288d into main Dec 18, 2024
27 checks passed
@lukasoppermann lukasoppermann deleted the component-diffBlob-tritanopia branch December 18, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant