Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 100ms duration #1149

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Add 100ms duration #1149

merged 1 commit into from
Dec 24, 2024

Conversation

lukasoppermann
Copy link
Contributor

Summary

Adds 100ms duration, to make it easier to build short transitions with matching delays

@lukasoppermann lukasoppermann requested review from a team as code owners December 24, 2024 09:20
Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: 38e8b64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Design Token Diff (CSS)

/css/base/motion/motion.css

+++ /home/runner/work/primitives/primitives/dist/css/base/motion/motion.css	2024-12-24 09:21:11.508457519 +0000
@@ -1,5 +1,6 @@
:root {
 --base-duration-0: 0ms;
+  --base-duration-100: 100ms;
 --base-duration-1000: 1s;
 --base-duration-200: 200ms;
 --base-duration-300: 300ms;

/css/primitives.css

+++ /home/runner/work/primitives/primitives/dist/css/primitives.css	2024-12-24 09:21:11.714460375 +0000
@@ -1,5 +1,6 @@
:root {
 --base-duration-0: 0ms;
+  --base-duration-100: 100ms;
 --base-duration-1000: 1s;
 --base-duration-200: 200ms;
 --base-duration-300: 300ms;

Copy link
Contributor

Design Token Diff (StyleLint)

/styleLint/base/motion/motion.json

+++ /home/runner/work/primitives/primitives/dist/styleLint/base/motion/motion.json	2024-12-24 09:21:11.508457519 +0000
@@ -13,6 +13,20 @@
   "path": ["base", "duration", "0"],
   "key": "{base.duration.0}"
 },
+  "base-duration-100": {
+    "$value": "100ms",
+    "$type": "duration",
+    "filePath": "src/tokens/base/motion/timing.json5",
+    "isSource": true,
+    "original": {
+      "$value": "100ms",
+      "$type": "duration"
+    },
+    "name": "base-duration-100",
+    "attributes": {},
+    "path": ["base", "duration", "100"],
+    "key": "{base.duration.100}"
+  },
 "base-duration-1000": {
   "$value": "1000ms",
   "$type": "duration",

Copy link
Contributor

Design Token Diff (Fallbacks)

/fallbacks/base/motion/motion.json

+++ /home/runner/work/primitives/primitives/dist/fallbacks/base/motion/motion.json	2024-12-24 09:21:11.508457519 +0000
@@ -5,6 +5,7 @@
 "--base-easing-easeInOut": [0.6, 0, 0.2, 1],
 "--base-duration-0": "0ms",
 "--base-duration-75": "75ms",
+  "--base-duration-100": "100ms",
 "--base-duration-200": "200ms",
 "--base-duration-300": "300ms",
 "--base-duration-400": "400ms",

@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 24, 2024 09:22 Inactive
@lukasoppermann lukasoppermann merged commit 24aa6fc into main Dec 24, 2024
29 checks passed
@lukasoppermann lukasoppermann deleted the add-100ms-duration branch December 24, 2024 09:33
@primer primer bot mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant