Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change codemirror.selectionBg to muted #178

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Change codemirror.selectionBg to muted #178

merged 3 commits into from
Jun 29, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jun 29, 2021

Currently text selection when editing a file is barely visible in HC:

Screen Shot 2021-06-29 at 9 11 22

This PR changes the selection from subtle to muted:

Light Dark Dark Dimmed Dark high contrast
Screen Shot 2021-06-29 at 9 10 23 Screen Shot 2021-06-29 at 9 10 35 Screen Shot 2021-06-29 at 9 10 46 Screen Shot 2021-06-29 at 20 30 42

This matches the accent.muted used for selection of code in "read-only" mode.

@simurai simurai requested a review from Juliusschaeper June 29, 2021 00:18
@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2021

🦋 Changeset detected

Latest commit: 0461344

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/9xgn6LEF6gvA1mqxYqkt4o31oSa7
✅ Preview: https://primitives-git-cm-selection-primer.vercel.app

Copy link
Contributor

@Juliusschaeper Juliusschaeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simurai simurai merged commit 8c52704 into main Jun 29, 2021
@simurai simurai deleted the cm-selection branch June 29, 2021 12:11
@github-actions github-actions bot mentioned this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants