Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic light high contrast setup #271

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Basic light high contrast setup #271

merged 3 commits into from
Nov 17, 2021

Conversation

Juliusschaeper
Copy link
Contributor

  • Added light high contrast palette colors
  • updated index file
  • added basic exceptions

@Juliusschaeper
Basic light high contrast setup
9aaa6a1 
- Added light high contrast palette colors
- updated index file
- added basic exceptions
@Juliusschaeper Juliusschaeper self-assigned this Nov 16, 2021
@Juliusschaeper Juliusschaeper requested a review from a team as a code owner November 16, 2021 15:39
@Juliusschaeper Juliusschaeper requested review from a team and siddharthkp November 16, 2021 15:39
@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 4d0fde8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 16, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/ADLyYQzbfGvonDNaXYQhAJzFevST
✅ Preview: https://primitives-git-light-high-contrast-colors-primer.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2021 •
edited
Loading

Variables changed 
No variables changed

simurai
simurai approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢👍

Docs preview

Screen.Recording.2021-11-17.at.10.46.44.mov

@simurai
Copy link
Contributor

simurai commented Nov 17, 2021

@Juliusschaeper One way to test this on dotcom without doing all the shipping:

  1. Download light_high_contrast.css.zip and unzip it.
  2. Open the "Advanced settings" in Safari.
  3. Load the light_high_contrast.css in the "Style sheet" option.
  4. Choose "None selected" to remove this override again.
Screen.Recording.2021-11-17.at.11.32.53.mov

@simurai
Copy link
Contributor

simurai commented Nov 17, 2021

Ok, browsed a bit around with the light_high_contrast.css above and haven't found big problems.

Except maybe these hard coded areas like the header and checks. But that's expected and we first need "nested themes" to improve that.

Screen Shot 2021-11-17 at 11 44 25

@Juliusschaeper Juliusschaeper merged commit f6e25d7 into main Nov 17, 2021
@Juliusschaeper Juliusschaeper deleted the light-high-contrast-colors branch November 17, 2021 16:41
@primer-css primer-css mentioned this pull request Nov 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees

@Juliusschaeper Juliusschaeper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Juliusschaeper @simurai