-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added border to topic and counters #279
Conversation
🦋 Changeset detectedLatest commit: 82d42fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/U3Xduo1JM5WURSCCpp5JC8ksaFvP |
Variables changed--- base/dist/scss/colors/_dark.scss 2021-11-30 09:55:08.676818799 +0000
+++ dist/scss/colors/_dark.scss 2021-11-30 09:54:56.324492393 +0000
@@ -159,2 +159,3 @@
--color-topic-tag-border: rgba(0,0,0,0);
+ --color-counter-border: rgba(0,0,0,0);
--color-select-menu-backdrop-border: #484f58;
--- base/dist/scss/colors/_dark_colorblind.scss 2021-11-30 09:55:08.700819343 +0000
+++ dist/scss/colors/_dark_colorblind.scss 2021-11-30 09:54:56.340492593 +0000
@@ -159,2 +159,3 @@
--color-topic-tag-border: rgba(0,0,0,0);
+ --color-counter-border: rgba(0,0,0,0);
--color-select-menu-backdrop-border: #484f58;
--- base/dist/scss/colors/_dark_dimmed.scss 2021-11-30 09:55:08.684818980 +0000
+++ dist/scss/colors/_dark_dimmed.scss 2021-11-30 09:54:56.328492443 +0000
@@ -159,2 +159,3 @@
--color-topic-tag-border: rgba(0,0,0,0);
+ --color-counter-border: rgba(0,0,0,0);
--color-select-menu-backdrop-border: #545d68;
--- base/dist/scss/colors/_dark_high_contrast.scss 2021-11-30 09:55:08.692819162 +0000
+++ dist/scss/colors/_dark_high_contrast.scss 2021-11-30 09:54:56.336492543 +0000
@@ -159,2 +159,3 @@
--color-topic-tag-border: #409eff;
+ --color-counter-border: rgba(0,0,0,0);
--color-select-menu-backdrop-border: #7a828e;
--- base/dist/scss/colors/_light.scss 2021-11-30 09:55:08.640817984 +0000
+++ dist/scss/colors/_light.scss 2021-11-30 09:54:56.284491892 +0000
@@ -159,2 +159,3 @@
--color-topic-tag-border: rgba(0,0,0,0);
+ --color-counter-border: rgba(0,0,0,0);
--color-select-menu-backdrop-border: rgba(0,0,0,0);
--- base/dist/scss/colors/_light_colorblind.scss 2021-11-30 09:55:08.672818708 +0000
+++ dist/scss/colors/_light_colorblind.scss 2021-11-30 09:54:56.316492293 +0000
@@ -159,2 +159,3 @@
--color-topic-tag-border: rgba(0,0,0,0);
+ --color-counter-border: rgba(0,0,0,0);
--color-select-menu-backdrop-border: rgba(0,0,0,0);
--- base/dist/scss/colors/_light_high_contrast.scss 2021-11-30 09:55:08.652818255 +0000
+++ dist/scss/colors/_light_high_contrast.scss 2021-11-30 09:54:56.300492092 +0000
@@ -158,3 +158,4 @@
--color-avatar-child-shadow: -2px -2px 0 rgba(255,255,255,0.8);
- --color-topic-tag-border: rgba(0,0,0,0);
+ --color-topic-tag-border: #0349b4;
+ --color-counter-border: #20252C;
--color-select-menu-backdrop-border: rgba(0,0,0,0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*This requires updating primer css to support counter border.
👍 Ok, yeah. I can start using the counter-border in Primer CSS.
Added
counter.border
* tocomponent light & dark
*This requires updating primer css to support counter border.
Changed
topicTag.border
andcounter.border
for increased contrast and visibility.