Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dark.scss #28

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Update dark.scss #28

merged 3 commits into from
Oct 15, 2020

Conversation

auareyou
Copy link
Contributor

I added some annotations and change the background model slightly. I also corrected a couple of variables that were pointing to the wrong color.

I added some annotations and change the background model slightly. I also corrected a couple of variables that were pointing to the wrong color.
@vercel
Copy link

vercel bot commented Oct 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/jv2ec0mg8
✅ Preview: https://primitives-git-auareyou-patch-3.primer.vercel.app

@auareyou auareyou changed the title Update.scss Update dark.scss Oct 14, 2020
Made changes to match dark.scss
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

We probably have to switch the values for bg-secondary <-> bg-tertiary in light. But can be done separately when updating Primer CSS.

@simurai simurai merged commit 1264a05 into mkt/color-modes Oct 15, 2020
@simurai simurai deleted the auareyou-patch-3 branch October 15, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants