Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert tooltips in dark mode #46

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Invert tooltips in dark mode #46

merged 2 commits into from
Mar 23, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Mar 17, 2021

This changes the tooltips to be inverted in dark mode.

Before After
Screen Shot 2021-03-17 at 11 08 13 Screen Shot 2021-03-17 at 11 00 04

It solves the problem where a tooltip is used on top of another "overlay" and becomes invisible. Using a light background might be fine since tooltips are small and only visible on hover.

@vercel
Copy link

vercel bot commented Mar 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/CbRbEaoRpsHhQfMCe5mtsZ1iGX7E
✅ Preview: https://primitives-git-tooltips-primer.vercel.app

Copy link

@josebalius josebalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a Codespaces perspective and since I reported it 😄

@auareyou
Copy link
Contributor

@simurai here's the change in specs for tooltips in dark mode and dimmed mode:
image

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2021

⚠️ No Changeset found

Latest commit: 53fa38f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@simurai
Copy link
Contributor Author

simurai commented Mar 23, 2021

here's the change in specs for tooltips in dark mode and dimmed mode:

Ok, updated in 53fa38f

@simurai simurai merged commit 325cc77 into release-4.0.0 Mar 23, 2021
@simurai simurai deleted the tooltips branch March 23, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants