Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dark toasts #49

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Update dark toasts #49

merged 1 commit into from
Mar 23, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Mar 23, 2021

This is a follow-up to https://github.com/github/primer/issues/57#issuecomment-804044793 and updates the dark toast colors:

image

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2021

⚠️ No Changeset found

Latest commit: 7b5b5bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/ExhZUVaHtiUoyCdSCDf7FzvicBC2
✅ Preview: https://primitives-git-toasts-primer.vercel.app

icon-bg: $gray-6,
icon-border: var(--color-border-primary),
icon-bg: $gray-4,
icon-border: $gray-3,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auareyou The icon-border is not defined in the spec here https://github.com/github/primer/issues/57#issuecomment-804044793, so I just used $gray-3 (one level higher than icon-bg).

@simurai simurai marked this pull request as ready for review March 23, 2021 03:32
@simurai simurai merged commit b90cb12 into release-4.0.0 Mar 23, 2021
@simurai simurai deleted the toasts branch March 23, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant