-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Primitives v8 colors #529
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
af22fc4
move over from old pr
langermank 180d645
remove old files
langermank d4d996c
replace decorative with muted
langermank fcc6841
remove decorative
langermank 405f202
fix high contrast
langermank f931a27
lukas' tests saving the day
langermank dad00b1
Create .changeset/cold-houses-swim.md
langermank b58db20
use correct alpha for muted bg in dark
langermank 3bb80ed
Merge branch 'main' into colors-primitives-v8
langermank 1f024b8
fix dark alpha
langermank 99be152
undo change to css build
langermank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@primer/primitives": patch | ||
| --- | ||
|
|
||
| Add Primitives v8 colors (private dist for testing) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ | |
| base: { | ||
| color: { | ||
| black: { | ||
| $value: '#1b1f24', | ||
| $value: '#1f2328', | ||
| $type: 'color', | ||
| }, | ||
| transparent: { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,242 @@ | ||
| { | ||
| topicTag: { | ||
| borderColor: { | ||
| $value: '{base.color.transparent}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| highlight: { | ||
| neutral: { | ||
| bgColor: { | ||
| $value: '{base.color.yellow.3}', | ||
| $type: 'color', | ||
| alpha: 0.4, | ||
| }, | ||
| }, | ||
| }, | ||
| page: { | ||
| header: { | ||
| bgColor: { | ||
| $value: '{bgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| }, | ||
| diffBlob: { | ||
| addition: { | ||
| fgColor: { | ||
| text: { | ||
| $value: '{fgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| num: { | ||
| $value: '{fgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| bgColor: { | ||
| num: { | ||
| $value: '{base.color.green.3}', | ||
| $type: 'color', | ||
| alpha: 0.3, | ||
| }, | ||
| line: { | ||
| $value: '{base.color.green.4}', | ||
| $type: 'color', | ||
| alpha: 0.15, | ||
| mix: null, | ||
| }, | ||
| word: { | ||
| $value: '{base.color.green.4}', | ||
| $type: 'color', | ||
| alpha: 0.4, | ||
| }, | ||
| }, | ||
| }, | ||
| deletion: { | ||
| fgColor: { | ||
| text: { | ||
| $value: '{fgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| num: { | ||
| $value: '{fgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| bgColor: { | ||
| num: { | ||
| $value: '{base.color.red.4}', | ||
| $type: 'color', | ||
| alpha: 0.3, | ||
| }, | ||
| line: { | ||
| $value: '{base.color.red.4}', | ||
| $type: 'color', | ||
| alpha: 0.15, | ||
| mix: null, | ||
| }, | ||
| word: { | ||
| $value: '{base.color.red.4}', | ||
| $type: 'color', | ||
| alpha: 0.4, | ||
| }, | ||
| }, | ||
| }, | ||
| hunk: { | ||
| bgColor: { | ||
| num: { | ||
| $value: '{borderColor.accent.muted}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| }, | ||
| expander: { | ||
| iconColor: { | ||
| $value: '{fgColor.muted}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| }, | ||
| diffStat: { | ||
| addition: { | ||
| bgColor: { | ||
| $value: '{bgColor.success.emphasis}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| }, | ||
| codeMirror: { | ||
| fgColor: { | ||
| $value: '{fgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| bgColor: { | ||
| $value: '{bgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| gutters: { | ||
| bgColor: { | ||
| $value: '{bgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| gutterMarker: { | ||
| fgColor: { | ||
| default: { | ||
| $value: '{bgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| muted: { | ||
| $value: '{fgColor.muted}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| }, | ||
| lineNumber: { | ||
| fgColor: { | ||
| $value: '{fgColor.muted}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| cursor: { | ||
| fgColor: { | ||
| $value: '{fgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| selection: { | ||
| bgColor: { | ||
| $value: '{borderColor.accent.muted}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| activeline: { | ||
| bgColor: { | ||
| $value: '{bgColor.neutral.muted}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| matchingBracket: { | ||
| fgColor: { | ||
| $value: '{fgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| lines: { | ||
| bgColor: { | ||
| $value: '{bgColor.default}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| syntax: { | ||
| fgColor: { | ||
| comment: { | ||
| $value: '{base.color.gray.3}', | ||
| $type: 'color', | ||
| }, | ||
| constant: { | ||
| $value: '{base.color.blue.2}', | ||
| $type: 'color', | ||
| }, | ||
| entity: { | ||
| $value: '{base.color.purple.2}', | ||
| $type: 'color', | ||
| }, | ||
| keyword: { | ||
| $value: '{base.color.red.3}', | ||
| $type: 'color', | ||
| }, | ||
| storage: { | ||
| $value: '{base.color.red.3}', | ||
| $type: 'color', | ||
| }, | ||
| string: { | ||
| $value: '{base.color.blue.1}', | ||
| $type: 'color', | ||
| }, | ||
| support: { | ||
| $value: '{base.color.blue.2}', | ||
| $type: 'color', | ||
| }, | ||
| variable: { | ||
| $value: '{base.color.orange.2}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| header: { | ||
| fgColor: { | ||
| default: { | ||
| $value: '{fgColor.onEmphasis}', | ||
| $type: 'color', | ||
| alpha: 0.7, | ||
| }, | ||
| logo: { | ||
| $value: '{fgColor.onEmphasis}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| bgColor: { | ||
| $value: '{base.color.gray.9}', | ||
| $type: 'color', | ||
| }, | ||
| borderColor: { | ||
| divider: { | ||
| $value: '{base.color.gray.3}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| }, | ||
| headerSearch: { | ||
| bgColor: { | ||
| $value: '{base.color.gray.9}', | ||
| $type: 'color', | ||
| }, | ||
| borderColor: { | ||
| $value: '{base.color.gray.6}', | ||
| $type: 'color', | ||
| }, | ||
| }, | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have another name for this effort? It would be v3 of renaming efforts, although it doesn't match Primitives's current semver version. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to refer to this as the next major (v8) release of Primitives vs. v3, which I think sounds a little nicer and more accurate! In v8 we will also ship all the sizing tokens without fallbacks, so it truly feels like a big major release.