Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figma tokens build process #665

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Figma tokens build process #665

merged 2 commits into from
Jul 20, 2023

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Jun 26, 2023 •
edited
Loading

Summary

This PR adds a build step to prepare primitives to be consumed by figma.

Todo

  • create json file with all files listed, so that they can be fetched
  • add transformers to transform tokens in a way that figma can consume
  • add collection data to tokens so that they can be added to the correct collection and mode in figma
  • evaluate how to best prepare files (e.g. should all themes be in one large file?)

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: a3574d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023 •
edited
Loading

Variables changed 
No variables changed

@lukasoppermann lukasoppermann force-pushed the @lukasopppermann/figma branch from ce79adb to 9d87edd Compare June 26, 2023 11:56
@lukasoppermann lukasoppermann temporarily deployed to github-pages June 26, 2023 11:59 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview June 26, 2023 11:59 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023 •
edited
Loading

Design Token Diff

No design tokens changed

@lukasoppermann lukasoppermann temporarily deployed to github-pages June 27, 2023 11:49 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview June 27, 2023 11:50 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages June 28, 2023 10:08 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview June 28, 2023 10:08 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages June 28, 2023 10:46 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview June 28, 2023 10:47 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages June 28, 2023 11:48 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview June 28, 2023 11:48 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages June 29, 2023 13:32 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview June 29, 2023 13:32 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 4, 2023 13:10 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 4, 2023 13:10 Inactive
@lukasoppermann lukasoppermann force-pushed the @lukasopppermann/figma branch 2 times, most recently from 1d0962e to 8eae656 Compare July 6, 2023 08:37
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 6, 2023 08:39 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 6, 2023 08:39 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 7, 2023 10:47 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 7, 2023 10:47 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 7, 2023 13:31 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 7, 2023 13:32 Inactive
@lukasoppermann lukasoppermann force-pushed the @lukasopppermann/figma branch from cc79734 to a8f8f6b Compare July 7, 2023 14:23
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 7, 2023 14:26 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 7, 2023 14:26 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 7, 2023 16:03 — with GitHub Actions Inactive
@lukasoppermann lukasoppermann requested review from a team and langermank July 13, 2023 12:46
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 13, 2023 16:37 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 13, 2023 16:37 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 14, 2023 07:56 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 14, 2023 07:56 Inactive
@lukasoppermann lukasoppermann force-pushed the @lukasopppermann/figma branch from 7137e33 to 854e105 Compare July 19, 2023 16:14
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 19, 2023 16:17 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 19, 2023 16:17 Inactive
@lukasoppermann lukasoppermann force-pushed the @lukasopppermann/figma branch 2 times, most recently from 277fce1 to 02c4a39 Compare July 19, 2023 16:25
@github-actions github-actions bot temporarily deployed to storybook-preview July 19, 2023 16:28 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 19, 2023 16:28 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 19, 2023 16:28 Inactive
@lukasoppermann lukasoppermann force-pushed the @lukasopppermann/figma branch from 02c4a39 to 924c5b5 Compare July 19, 2023 16:30
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 19, 2023 16:33 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 19, 2023 16:34 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 19, 2023 16:48 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 19, 2023 16:48 Inactive
@lukasoppermann lukasoppermann force-pushed the @lukasopppermann/figma branch from 698b049 to 85b456d Compare July 19, 2023 16:52
@lukasoppermann lukasoppermann force-pushed the @lukasopppermann/figma branch from 85b456d to a3574d6 Compare July 19, 2023 16:53
@github-actions github-actions bot temporarily deployed to storybook-preview July 19, 2023 16:55 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 19, 2023 16:56 Inactive
langermank
langermank approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Not going to read through the token src files but I think if there was a bug we would see a test failure 😄 🚀

@lukasoppermann lukasoppermann merged commit 360a8b8 into main Jul 20, 2023
@lukasoppermann lukasoppermann deleted the @lukasopppermann/figma branch July 20, 2023 11:09
@primer-css primer-css mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasoppermann @langermank