Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figma token name transformer #698

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Figma token name transformer #698

merged 2 commits into from
Jul 21, 2023

Conversation

lukasoppermann
Copy link
Contributor

Summary

Added transformer that changes specific token names to be better represented in figma

@lukasoppermann lukasoppermann requested a review from a team as a code owner July 21, 2023 08:41
@lukasoppermann lukasoppermann requested review from a team, tobiasahlin and broccolinisoup July 21, 2023 08:41
@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: dfc4f8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023 •
edited
Loading

Variables changed 
No variables changed

@lukasoppermann lukasoppermann temporarily deployed to github-pages July 21, 2023 08:43 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 21, 2023 08:44 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 21, 2023 08:44 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023 •
edited
Loading

Design Token Diff

/css/functional/themes/dark-colorblind.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-colorblind.css	2023-07-21 13:38:55.769723426 +0000
@@ -188,7 +188,7 @@
 --fgColor-muted: #7d8590;
 --fgColor-onEmphasis: #ffffff;
 --fgColor-disabled: #8b949e;
-  --fgColor-link-rest: #2f81f7;
+  --fgColor-link: #2f81f7;
 --fgColor-accent: #2f81f7;
 --fgColor-success: #58a6ff;
 --fgColor-attention: #d29922;
@@ -589,7 +589,7 @@
   --fgColor-muted: #7d8590;
   --fgColor-onEmphasis: #ffffff;
   --fgColor-disabled: #8b949e;
-    --fgColor-link-rest: #2f81f7;
+    --fgColor-link: #2f81f7;
   --fgColor-accent: #2f81f7;
   --fgColor-success: #58a6ff;
   --fgColor-attention: #d29922;

/css/functional/themes/dark-dimmed.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-dimmed.css	2023-07-21 13:38:54.861724954 +0000
@@ -188,7 +188,7 @@
 --fgColor-muted: #6d7986;
 --fgColor-onEmphasis: #cdd9e5;
 --fgColor-disabled: #768390;
-  --fgColor-link-rest: #3b7cdb;
+  --fgColor-link: #3b7cdb;
 --fgColor-accent: #3b7cdb;
 --fgColor-success: #57ab5a;
 --fgColor-attention: #c69026;
@@ -589,7 +589,7 @@
   --fgColor-muted: #6d7986;
   --fgColor-onEmphasis: #cdd9e5;
   --fgColor-disabled: #768390;
-    --fgColor-link-rest: #3b7cdb;
+    --fgColor-link: #3b7cdb;
   --fgColor-accent: #3b7cdb;
   --fgColor-success: #57ab5a;
   --fgColor-attention: #c69026;

/css/functional/themes/dark-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-high-contrast.css	2023-07-21 13:38:56.169722753 +0000
@@ -188,7 +188,7 @@
 --fgColor-muted: #f0f3f6;
 --fgColor-onEmphasis: #0a0c10;
 --fgColor-disabled: #bdc4cc;
-  --fgColor-link-rest: #409eff;
+  --fgColor-link: #409eff;
 --fgColor-accent: #409eff;
 --fgColor-success: #26cd4d;
 --fgColor-attention: #f0b72f;
@@ -589,7 +589,7 @@
   --fgColor-muted: #f0f3f6;
   --fgColor-onEmphasis: #0a0c10;
   --fgColor-disabled: #bdc4cc;
-    --fgColor-link-rest: #409eff;
+    --fgColor-link: #409eff;
   --fgColor-accent: #409eff;
   --fgColor-success: #26cd4d;
   --fgColor-attention: #f0b72f;

/css/functional/themes/dark-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-tritanopia.css	2023-07-21 13:38:55.377724086 +0000
@@ -188,7 +188,7 @@
 --fgColor-muted: #7d8590;
 --fgColor-onEmphasis: #ffffff;
 --fgColor-disabled: #8b949e;
-  --fgColor-link-rest: #2f81f7;
+  --fgColor-link: #2f81f7;
 --fgColor-accent: #2f81f7;
 --fgColor-success: #58a6ff;
 --fgColor-attention: #d29922;
@@ -589,7 +589,7 @@
   --fgColor-muted: #7d8590;
   --fgColor-onEmphasis: #ffffff;
   --fgColor-disabled: #8b949e;
-    --fgColor-link-rest: #2f81f7;
+    --fgColor-link: #2f81f7;
   --fgColor-accent: #2f81f7;
   --fgColor-success: #58a6ff;
   --fgColor-attention: #d29922;

/css/functional/themes/dark.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark.css	2023-07-21 13:38:54.421725695 +0000
@@ -188,7 +188,7 @@
 --fgColor-muted: #7d8590;
 --fgColor-onEmphasis: #ffffff;
 --fgColor-disabled: #8b949e;
-  --fgColor-link-rest: #2f81f7;
+  --fgColor-link: #2f81f7;
 --fgColor-accent: #2f81f7;
 --fgColor-success: #3fb950;
 --fgColor-attention: #d29922;
@@ -589,7 +589,7 @@
   --fgColor-muted: #7d8590;
   --fgColor-onEmphasis: #ffffff;
   --fgColor-disabled: #8b949e;
-    --fgColor-link-rest: #2f81f7;
+    --fgColor-link: #2f81f7;
   --fgColor-accent: #2f81f7;
   --fgColor-success: #3fb950;
   --fgColor-attention: #d29922;

/css/functional/themes/light-colorblind.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-colorblind.css	2023-07-21 13:38:53.517727216 +0000
@@ -189,7 +189,7 @@
 --fgColor-muted: #636c76;
 --fgColor-onEmphasis: #ffffff;
 --fgColor-disabled: #8c959f;
-  --fgColor-link-rest: #0969da;
+  --fgColor-link: #0969da;
 --fgColor-accent: #0969da;
 --fgColor-success: #0969da;
 --fgColor-attention: #9a6700;
@@ -590,7 +590,7 @@
   --fgColor-muted: #636c76;
   --fgColor-onEmphasis: #ffffff;
   --fgColor-disabled: #8c959f;
-    --fgColor-link-rest: #0969da;
+    --fgColor-link: #0969da;
   --fgColor-accent: #0969da;
   --fgColor-success: #0969da;
   --fgColor-attention: #9a6700;

/css/functional/themes/light-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-high-contrast.css	2023-07-21 13:38:53.997726408 +0000
@@ -189,7 +189,7 @@
 --fgColor-muted: #0e1116;
 --fgColor-onEmphasis: #ffffff;
 --fgColor-disabled: #4b535d;
-  --fgColor-link-rest: #023b95;
+  --fgColor-link: #023b95;
 --fgColor-accent: #023b95;
 --fgColor-success: #055d20;
 --fgColor-attention: #744500;
@@ -590,7 +590,7 @@
   --fgColor-muted: #0e1116;
   --fgColor-onEmphasis: #ffffff;
   --fgColor-disabled: #4b535d;
-    --fgColor-link-rest: #023b95;
+    --fgColor-link: #023b95;
   --fgColor-accent: #023b95;
   --fgColor-success: #055d20;
   --fgColor-attention: #744500;

/css/functional/themes/light-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-tritanopia.css	2023-07-21 13:38:53.065727977 +0000
@@ -189,7 +189,7 @@
 --fgColor-muted: #636c76;
 --fgColor-onEmphasis: #ffffff;
 --fgColor-disabled: #8c959f;
-  --fgColor-link-rest: #0969da;
+  --fgColor-link: #0969da;
 --fgColor-accent: #0969da;
 --fgColor-success: #0969da;
 --fgColor-attention: #9a6700;
@@ -590,7 +590,7 @@
   --fgColor-muted: #636c76;
   --fgColor-onEmphasis: #ffffff;
   --fgColor-disabled: #8c959f;
-    --fgColor-link-rest: #0969da;
+    --fgColor-link: #0969da;
   --fgColor-accent: #0969da;
   --fgColor-success: #0969da;
   --fgColor-attention: #9a6700;

/css/functional/themes/light.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light.css	2023-07-21 13:38:52.481728959 +0000
@@ -189,7 +189,7 @@
 --fgColor-muted: #636c76;
 --fgColor-onEmphasis: #ffffff;
 --fgColor-disabled: #8c959f;
-  --fgColor-link-rest: #0969da;
+  --fgColor-link: #0969da;
 --fgColor-accent: #0969da;
 --fgColor-success: #1a7f37;
 --fgColor-attention: #9a6700;
@@ -590,7 +590,7 @@
   --fgColor-muted: #636c76;
   --fgColor-onEmphasis: #ffffff;
   --fgColor-disabled: #8c959f;
-    --fgColor-link-rest: #0969da;
+    --fgColor-link: #0969da;
   --fgColor-accent: #0969da;
   --fgColor-success: #1a7f37;
   --fgColor-attention: #9a6700;

@lukasoppermann lukasoppermann temporarily deployed to github-pages July 21, 2023 11:12 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 21, 2023 11:12 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 21, 2023 11:27 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 21, 2023 11:27 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 21, 2023 12:47 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 21, 2023 12:47 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 21, 2023 12:48 Inactive
@lukasoppermann lukasoppermann merged commit 870cc60 into main Jul 21, 2023
@lukasoppermann lukasoppermann deleted the figmaNameTransformer branch July 21, 2023 13:40
@primer-css primer-css mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasahlin tobiasahlin Awaiting requested review from tobiasahlin tobiasahlin is a code owner automatically assigned from primer/css-reviewers

@broccolinisoup broccolinisoup Awaiting requested review from broccolinisoup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann