-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix npm release #737
Fix npm release #737
Conversation
|
Variables changedNo variables changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this @rezrah, but I'm hesitant to merge these changes. I just finished a bunch of work to move away from GPR_AUTH_TOKEN_SHARED
in favor of a GitHub App. The trouble with GPR_AUTH_TOKEN_SHARED
is that it will expire over time, whereas the tokens issued by an App are sort-lived and issued on an as-needed basis. I believe the problem @langermank ran into yesterday is due to data missing from a GitHub API response, not an issue with the access token or the permissions attached to it. I'm currently looking into a fix.
Absolutely fine 👍. Will close this and allow you to investigate, as i'll be unable to look into it further until Monday now.
Inclined to agree with this, as it could be related to the commit history thing raised in the changeset support issue. Have you tried backing out this commit and seeing if that fixes anything? |
@rezrah I see the same failure for both our release.yml and release_canary.yml workflows. The canary one doesn't even get an auth token 🤔 I haven't tried backing out the commit, but that's a good idea. Thanks! |
Turns out this was caused by a git hash collision. I was able to fix things in the short term by reverting the offending commit, then reverting the revert. I've also submitted a PR to the changesets project to get this fixed long-term. |
Summary
🚧 WIP
Fixing the library release to npm by using our Primer org workflow instead of a custom, local one.
What approach did you choose and why?
What should reviewers focus on?
Contributor checklist:
Reviewer checklist: