Add border prop for color in storybook #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasoppermann
added
the
skip changeset
|
Variables changedNo variables changed |
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
added
the
update snapshots
github-actions
bot
removed
the
update snapshots
lukasoppermann
force-pushed
the
storybook-update
branch
from
2b1ec0b to
a3a50f6
Compare
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
reviewed
Oct 30, 2023
| style={{ | ||
| backgroundColor: `var(--${color})`, | ||
| color: textColor, | ||
| border: border ? '1px solid var(--color-scale-gray-1)' : 'none', |
There was a problem hiding this comment.
Suggested change
| border: border ? '1px solid var(--color-scale-gray-1)' : 'none', | |
| border: border ? '1px solid var(--borderColor-default)' : 'none', |
What do you think of using the default border color?
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add border prop for color in storybook
List of notable changes:
What should reviewers focus on?
Steps to test: