Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax for css classes to variables #779

Merged
merged 10 commits into from
Nov 22, 2023
Merged

Conversation

lukasoppermann
Copy link
Contributor

Summary

PoC adding css class to code syntax

@lukasoppermann lukasoppermann requested a review from a team as a code owner November 21, 2023 13:30
@lukasoppermann lukasoppermann requested review from a team, rezrah and siddharthkp November 21, 2023 13:30
Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 04c62c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 21, 2023

Variables changed
No variables changed

Copy link
Contributor

Design Token Diff

No design tokens changed

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions to use gap utilities. These are hidden somewhere in dotcom but I happen to know they exist 😆 I cross referenced everything else you added with PCSS docs, looks great!

src/tokens/functional/size/size.json Outdated Show resolved Hide resolved
src/tokens/functional/size/size.json Outdated Show resolved Hide resolved
src/tokens/functional/size/size.json Outdated Show resolved Hide resolved
lukasoppermann and others added 4 commits November 22, 2023 18:14
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to storybook-preview November 22, 2023 17:19 Inactive
@lukasoppermann lukasoppermann merged commit 105afb5 into main Nov 22, 2023
26 checks passed
@lukasoppermann lukasoppermann deleted the lukasoppermann-syntax branch November 22, 2023 17:21
@primer primer bot mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants