Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix danger fgColor high contrast dark #827

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Fix danger fgColor high contrast dark #827

merged 3 commits into from
Mar 7, 2024

Conversation

langermank
Copy link
Contributor

Noticed this during some manual testing

dark high contrast buttons

Copy link

changeset-bot bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: 3c477b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Variables changed
No variables changed

@langermank langermank added the update snapshots Update visual regression test snapshots label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Design Token Diff

/css/functional/themes/dark-high-contrast.css

+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-high-contrast.css	2024-03-07 01:24:56.815900622 +0000
@@ -147,7 +147,7 @@
 --button-outline-borderColor-hover: #ffffff1a;
 --button-outline-borderColor-selected: #ffffff1a;
 --button-outline-shadow-selected: 0px 0px 0px 0px #000000;
-  --button-danger-fgColor-rest: #ff8080;
+  --button-danger-fgColor-rest: #ff9492;
 --button-danger-fgColor-hover: #ffffff;
 --button-danger-fgColor-active: #ffffff;
 --button-danger-fgColor-disabled: #ff808080;
@@ -558,7 +558,7 @@
   --button-outline-borderColor-hover: #ffffff1a;
   --button-outline-borderColor-selected: #ffffff1a;
   --button-outline-shadow-selected: 0px 0px 0px 0px #000000;
-    --button-danger-fgColor-rest: #ff8080;
+    --button-danger-fgColor-rest: #ff9492;
   --button-danger-fgColor-hover: #ffffff;
   --button-danger-fgColor-active: #ffffff;
   --button-danger-fgColor-disabled: #ff808080;

@github-actions github-actions bot temporarily deployed to storybook-preview March 7, 2024 01:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview March 7, 2024 01:04 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Mar 7, 2024
@langermank langermank marked this pull request as ready for review March 7, 2024 01:19
@langermank langermank requested review from a team as code owners March 7, 2024 01:19
@langermank langermank merged commit 59be710 into main Mar 7, 2024
26 checks passed
@langermank langermank deleted the hc-danger-button branch March 7, 2024 17:18
@primer primer bot mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants