-
Notifications
You must be signed in to change notification settings - Fork 561
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed: Ensure Header component uses proper semantic header HTML tag (#…
…3533) * Fixed: Ensure Header component uses proper semantic header HTML tag * Fix: Ensure Header component uses proper semantic header HTML tag * Test: Snapshots for Header component * Change div to header for test case --------- Co-authored-by: Josh Black <joshblack@github.com>
- Loading branch information
1 parent
311c8c9
commit 33b6055
Showing
4 changed files
with
10 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@primer/react': patch | ||
--- | ||
|
||
Changed div tag to HTML semantic tag header for Header (file Header.tsx) component. | ||
|
||
<!-- Changed components: _none_ --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,7 +73,7 @@ exports[`Header renders consistently 1`] = ` | |
flex-wrap: nowrap; | ||
} | ||
<div | ||
<header | ||
className="c0" | ||
/> | ||
`; |