Skip to content

Commit

Permalink
SelectPanel: Add role="dialog" to overlay (#3310)
Browse files Browse the repository at this point in the history
* Add role="dialog" to selectpanel overlay

* Create curvy-windows-walk.md
  • Loading branch information
colebemis authored May 22, 2023
1 parent d1dc42a commit 5746c74
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/curvy-windows-walk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

SelectPanel: Add `role="dialog"` to overlay
2 changes: 1 addition & 1 deletion src/SelectPanel/SelectPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export function SelectPanel({
open={open}
onOpen={onOpen}
onClose={onClose}
overlayProps={overlayProps}
overlayProps={{role: 'dialog', ...overlayProps}}
focusTrapSettings={focusTrapSettings}
focusZoneSettings={focusZoneSettings}
>
Expand Down

0 comments on commit 5746c74

Please sign in to comment.