Add aria-expanded back to AnchoredOverlay (#4456)

* Adds `aria-expanded="false"` back to `AnchoredOverlay` * Add changeset
primer · Jun 6, 2024 · 65f2cd1 · 65f2cd1
1 parent 6cbbc49
commit 65f2cd1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/chatty-phones-admire.md b/.changeset/chatty-phones-admire.md
@@ -0,0 +1,5 @@
+---
+'@primer/react': patch
+---
+
+Adds full `aria-expanded` (true/false) state to `AnchoredOverlay`, and components that consume it
diff --git a/packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx b/packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx
@@ -172,7 +172,7 @@ export const AnchoredOverlay: React.FC<React.PropsWithChildren<AnchoredOverlayPr
           ref: anchorRef,
           id: anchorId,
           'aria-haspopup': 'true',
-          'aria-expanded': open ? 'true' : undefined,
+          'aria-expanded': open,
           tabIndex: 0,
           onClick: onAnchorClick,
           onKeyDown: onAnchorKeyDown,