Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconButton should have a tooltip by default #3137

Closed
khiga8 opened this issue Apr 7, 2023 · 3 comments
Closed

IconButton should have a tooltip by default #3137

khiga8 opened this issue Apr 7, 2023 · 3 comments
Labels
accessibility component: Button Issues related to the Button component react

Comments

@khiga8
Copy link
Contributor

khiga8 commented Apr 7, 2023

Having a visible label for an IconButton will help users with cognitive disabilities and increase usability for everyone, since it's not always obvious from the icon what action is possible.

In PVC, all IconButton default to having a tooltip (IconButton PVC docs). I recall this decision was made after input from accessibility design. Could we follow the same pattern here?

Relates to: https://github.com/github/accessibility-audits/issues/3171

@joshblack joshblack added component: Button Issues related to the Button component accessibility labels Apr 7, 2023
@iansan5653
Copy link
Contributor

Related to (possibly duplicate of):

@broccolinisoup
Copy link
Member

This might need first releasing the Tooltip remediations #3169

@lesliecdubs
Copy link
Member

Thanks all, we're going to close this one as a duplicate of #2008. Also agree we should try to ship the Tooltip accessibility remediations #3169 as a next step!

@lesliecdubs lesliecdubs closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility component: Button Issues related to the Button component react
Projects
None yet
Development

No branches or pull requests

6 participants