Tooltip: Revert tooltip remediations until resolving breaking changes at dotcom #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e6a5db6.
|
size-limit report 📦
|
|
cc @TylerJDev |
joshblack
approved these changes
Apr 14, 2023
colebemis
approved these changes
Apr 14, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Tooltipcomponent remediations and refactor causes breaking changes at dotcom and we are reverting the changes back until we resolve the issues.PR that we are reverting: #3032
Context
Some of the mis-usages of
Tooltipeither causes breaking changes or requires collaboration with the feature teams (potentially design input) to find a way to convey the tooltip information in other ways because some tooltips are used on non-interactive elements and we should be correcting them. Here (Hubbers only link) is a good example of a breaking change and a usage that requires collaboration to be corrected.In this usage (Hubbers only link), folks use
StyledOcticonas a trigger element forTooltip. The reason it breaks is thatStyledOcticonsare not usingReact.forwardRef()and in the new implementation we are trying to giverefto the trigger element to do some checks for accessibility. See error log (Hubbers only link) and we have an issue filed for our icons to useReact.forwardRef()as well. The plan is to revert the PR back and take this issue into the design office hours to see how we are going to address the breaking changes.