Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tooltip): update TypeScript types for TooltipProps #3159

Merged
merged 3 commits into from
Apr 12, 2023
Merged

fix(Tooltip): update TypeScript types for TooltipProps #3159

merged 3 commits into from
Apr 12, 2023

Conversation

joshblack
Copy link
Member

Closes #3158

Changelog

New

  • Add type test for "additional props" like id, style, etc

Changed

  • Rename TooltipEL to StyledTooltip (super cosmetic change, let me know if I should revert it back!)
  • Remove explicit generic from the styled tooltip
  • Update TooltipProps to intersect with ComponentProps<typeof StyledTooltip>

Removed

@joshblack joshblack requested review from broccolinisoup and a team April 12, 2023 15:02
@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 3bb0774

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 95.77 KB (-0.01% 🔽)
dist/browser.umd.js 96.38 KB (-0.01% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-3159 April 12, 2023 15:11 Inactive
broccolinisoup
broccolinisoup approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshblack joshblack enabled auto-merge April 12, 2023 21:29
@joshblack joshblack added this pull request to the merge queue Apr 12, 2023
Merged via the queue into main with commit e6a5db6 Apr 12, 2023
@joshblack joshblack deleted the fix/update-ts-types-tooltip branch April 12, 2023 21:41
@primer-css primer-css mentioned this pull request Apr 12, 2023
Merged
broccolinisoup added a commit that referenced this pull request Apr 13, 2023
@broccolinisoup
Revert "fix(Tooltip): update TypeScript types for TooltipProps (#3159)"
11182c4 
This reverts commit e6a5db6.
broccolinisoup added a commit that referenced this pull request Apr 17, 2023
@broccolinisoup
Tooltip: Revert tooltip remediations until resolving breaking changes…
86655ad 
… at dotcom (#3169)

* Revert "fix(Tooltip): update TypeScript types for TooltipProps (#3159)"

This reverts commit e6a5db6.

* Revert "Tooltip: Update the component markup for a11y remediations & refactor the existing styles towards more static styling (#3032)"

This reverts commit 1588989.
broccolinisoup pushed a commit that referenced this pull request May 4, 2023
@joshblack @broccolinisoup
fix(Tooltip): update TypeScript types for TooltipProps (#3159)
66c2970 
* fix(Tooltip): update TypeScript types for TooltipProps

* chore: add changeset

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update types for Tooltip in main
2 participants
@joshblack @broccolinisoup