Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button with invisible variant has no disabled styling differences #3167

Closed
mattcosta7 opened this issue Apr 13, 2023 · 1 comment · Fixed by #3185
Closed

Button with invisible variant has no disabled styling differences #3167

mattcosta7 opened this issue Apr 13, 2023 · 1 comment · Fixed by #3185
Assignees
@radglob
Labels
bug Something isn't working component: Button Issues related to the Button component design react size: sand

Comments

@mattcosta7
Copy link
Collaborator

Description

Button variant 'invisible' has no discernible disabled styling. In these examples, an invisible and outline button are disabled and enabled - but it's only noticeable which is which for the outline variant

Enabled

Screenshot 2023-04-13 at 5 24 09 PM

Disabled

Screenshot 2023-04-13 at 5 24 03 PM

Steps to reproduce

disabled an invisible variant button that has text in it

Version

latest

Browser

Chrome
@mattcosta7 mattcosta7 added the bug Something isn't working label Apr 13, 2023
@siddharthkp
Copy link
Member

siddharthkp commented Apr 17, 2023 •
edited
Loading

primer/css handles this well:

image

@joshblack joshblack added the component: Button Issues related to the Button component label Apr 17, 2023
@radglob radglob mentioned this issue Apr 17, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radglob radglob

Labels
bug Something isn't working component: Button Issues related to the Button component design react size: sand
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure disabled invisible buttons have the right text color. primer/react
6 participants
@radglob @siddharthkp @joshblack @lesliecdubs @mattcosta7 @primer-css