Ensure disabled invisible buttons have the right text color.

[radglob]

Made a change to not set [data-no-visuals=true] on invisible button variants. This was overriding the color that we want buttons to be.

This might not be the optimal way of handling this, but a) it seemed better than setting !important and b) I don't really know what [data-no-visuals] does except for set specific colors. If there's a semantic meaning to this, I'm happy to try a different approach.

Closes #3167

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

• Added/updated tests
• Added/updated documentation
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0d8f221

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	95.61 KB (+0.02% 🔺)
dist/browser.umd.js	96.17 KB (+0.01% 🔺)

[langermank]

Chatted on Slack, but this change breaks the design of the invisible button when its not disabled. I think just adding a specific selector for disabled makes sense here.

'&:disabled[data-no-visuals]': {
        color: 'primer.fg.disabled',
        '[data-component=ButtonCounter]': {
          color: 'inherit',
        },
      },