Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate button components to TypeScript #1017

Merged
merged 14 commits into from
Feb 8, 2021
Merged

feat: Migrate button components to TypeScript #1017

merged 14 commits into from
Feb 8, 2021

Commits on Feb 4, 2021

  1. feat: Migrate button components to TypeScript

    @smockle
    smockle committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    a4dce5d View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. fix: Import named import to make 'npm run dist' pass

    @smockle
    smockle committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    2402cd7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into smockle/button

    @smockle
    smockle committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    14ac1ef View commit details
    Browse the repository at this point in the history

  3. fix: Restore propTypes. Restore default exports. Rename props used by… 

    … styled components.
    @smockle
    smockle committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a4ffc03 View commit details
    Browse the repository at this point in the history

  4. chore: Downgrade non-breaking button changes to 'patch'

    @smockle
    smockle committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a17ff07 View commit details
    Browse the repository at this point in the history

  5. fix: TS2688 

    microsoft/TypeScript#27956
> These errors occur when you have subdirectories of a typeRoots directory…that do not contain index.d.ts files.
    @smockle
    smockle committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    942a11c View commit details
    Browse the repository at this point in the history

  6. fix: Fix types in Button story

    @smockle
    smockle committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    9218fe4 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2021

  1. fix: Remove 'ButtonBaseProps' where it’s inferable

    @smockle
    smockle committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    1d60b55 View commit details
    Browse the repository at this point in the history

  2. fix: Don’t add types to 'ButtonBaseProps' that 'ButtonBase' doesn’t use 

    Instead, share these via a different type ('ButtonSystemProps').
    @smockle
    smockle committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    7f8997e View commit details
    Browse the repository at this point in the history

  3. fix: Infer 'ButtonGroup'’s props type

    @smockle
    smockle committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    8996990 View commit details
    Browse the repository at this point in the history

  4. feat: Export prop types alongside components

    @smockle
    smockle committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    e3aed73 View commit details
    Browse the repository at this point in the history

  5. fix: Apparently 'sx' is not 'compose'able, so apply it separately fro… 

    …m other 'buttonSystemProps'
    @smockle
    smockle committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    80317da View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. chore: Change file extension (js -> tsx) for tests and snapshots

    @smockle
    smockle committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    6e411c4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into smockle/button

    @colebemis
    colebemis authored Feb 8, 2021
    Configuration menu
    Copy the full SHA
    7a24774 View commit details
    Browse the repository at this point in the history