-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Pagination to TypeScript #1047
Conversation
🦋 Changeset detectedLatest commit: a5389b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/6s0z7dkb3 |
forgot to export PaginationProps! done in 43c79d6 |
8fb049d should fix the last failing TS error 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍 Just left one suggestion about the PaginationProps type
21af95e
to
53edf5e
Compare
Co-authored-by: Cole Bemis <colebemis@github.com>
53edf5e
to
cf6bb0b
Compare
This PR migrates the
Pagination
component to TypeScript as part of the TypeScript refactor.