-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typos #2040
docs: fix typos #2040
Commits on Apr 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b4d325d - Browse repository at this point
Copy the full SHA b4d325dView commit details
Commits on Apr 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 21a0b6e - Browse repository at this point
Copy the full SHA 21a0b6eView commit details
Commits on Aug 1, 2022
-
Namespace UnderlineNav (primer#2053)
* namespace underline classes? * snippity snaps * Create quick-toys-fly.md
Configuration menu - View commit details
-
Copy full SHA for ea5858d - Browse repository at this point
Copy the full SHA ea5858dView commit details -
Version Packages (primer#2034)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a0b5f4e - Browse repository at this point
Copy the full SHA a0b5f4eView commit details -
Select component a11y fixes (primer#2038)
* fixes disabled option colors for all browsers (Firefox had the most issues) * fixes custom arrow color for disabled state and Windows high contrast mode, and hacks around Firefox quirks * updates SelectInput stories to use FormControl * makes cursor behavior consistent for inputs * removes redundant ARIA attributes from <select> * updates tests and snapshots * adds changeset * fixes media query for forced colors (high contrast mode) * hacks around Firefox Windows high-contrast mode quirk * addresses a11y feedback * fixes linting
Configuration menu - View commit details
-
Copy full SHA for 68a8630 - Browse repository at this point
Copy the full SHA 68a8630View commit details -
Finish updating global focus styles (primer#2050)
* updates focus styles that do not match the Primer CSS implementation * updates ThemeSwitcher to render ActionMenu instead of DropdownMenu * explicitly sets outline-offset in global focus styles instead of adding a new style that 'beats' the default 2px * update snapshots * fixes cross-browser issues for global focus styles * fixes unintentional laggy focus style update on SubNav * updates focus styles for UnderlineNav * DRY button focus styles * updates snapshots * adds changeset * fixes type error * revert themePreval snapshot update
Configuration menu - View commit details
-
Copy full SHA for 000fa72 - Browse repository at this point
Copy the full SHA 000fa72View commit details -
Tooltip: anchoredPosition + IconButton (primer#2006)
* Add breaking story * Add memex story * use behaviors deploy preview * add tooltip triangle * update snapshot * add label tooltips for story * update @primer/behaviors to latest * lint: remove unused import * Refactor Tooltip * Use Tooltip in IconButton * Add triangle styles for all directions * Add docs * Added delay * change ReactElement to ReactNode * keep ReactElement * Add tests! * compatible types :) * Fix docs * update snapshots * update behaviors to next minor * update snapshots * Fix IconButton duplicate label * missed a spot! * Fix Button story with tooltip * Apply suggestions from code review Co-authored-by: Cole Bemis <colebemis@github.com> * fix alignment with span Co-authored-by: Cole Bemis <colebemis@github.com>
Configuration menu - View commit details
-
Copy full SHA for b2bc8a0 - Browse repository at this point
Copy the full SHA b2bc8a0View commit details -
Implement NavList component (part 1) (primer#2058)
* Create NavList component * Implement NavList subcomponents * Reset font weight of trailing visual * Export NavList from drafts * Update NavList docs * Update NavList.mdx * Add children to props type * Add NavList tests * Create breezy-cooks-destroy.md * Pass props to underlying nav element * Show divider between groups * Update snapshot
Configuration menu - View commit details
-
Copy full SHA for efbf0cf - Browse repository at this point
Copy the full SHA efbf0cfView commit details -
ThemeProvider: Fix theme sync with system settings (primer#2048)
* disable theme decorator for themeprovider story * remove incorrect effect * Create wicked-boats-allow.md Co-authored-by: Mike Perrotti <mperrotti@github.com>
Configuration menu - View commit details
-
Copy full SHA for bb1681b - Browse repository at this point
Copy the full SHA bb1681bView commit details -
Move theme decorator into helper util (primer#2044)
* Move theme decorator into helper util * fix height * is addons import the problem? * does this work better for consumer-tests? * yep, deep import doesn't work either * add option to disable theme decorator on a story level Co-authored-by: Mike Perrotti <mperrotti@github.com>
Configuration menu - View commit details
-
Copy full SHA for fe3c0a8 - Browse repository at this point
Copy the full SHA fe3c0a8View commit details -
Add missing changelog for primer#2006! (primer#2069)
* Create improved-tooltip.md * Create iconbutton-default-tooltip.md * typo lol
Configuration menu - View commit details
-
Copy full SHA for 262d1ad - Browse repository at this point
Copy the full SHA 262d1adView commit details -
Implement NavList.SubNav (primer#2064)
* wip subnav * Add active prop to ActionList.Item * Handle nested current item * Add simple storybook story * Update snapshot * Stub tests * Use NavList in PageLayout story * Add test case todo * Fix sx typescript error * Add NavList.Item test * Add subnav tests * Add support for as="button" to ActionList.Item * Add nested subnav test * Update docs * Use spacing primitive * Reset marginY for safari * Document active prop * Create strong-nails-sip.md * Update snapshots
Configuration menu - View commit details
-
Copy full SHA for 9bdfdb3 - Browse repository at this point
Copy the full SHA 9bdfdb3View commit details -
Update issue templates for this repo to include redirects to pattern … (
primer#2063) * Update issue templates for this repo to include redirects to pattern proposal and request issues * Delete component proposal issue template * Update pattern discussion URL
Configuration menu - View commit details
-
Copy full SHA for 1611055 - Browse repository at this point
Copy the full SHA 1611055View commit details -
Fix ButtonGroup component and add docs (primer#2054)
* Make ButtonGroup display inline-flex * Create documentation page for ButtonGroup * Update Button docs * Create six-mirrors-call.md * Update tests * Update stories * Update six-mirrors-call.md
Configuration menu - View commit details
-
Copy full SHA for e46a318 - Browse repository at this point
Copy the full SHA e46a318View commit details -
ActionMenu: adjust width based on padding (primer#2080)
* adjust width based on padding * update snapshost
Configuration menu - View commit details
-
Copy full SHA for 69d12e0 - Browse repository at this point
Copy the full SHA 69d12e0View commit details -
Form component design tweaks (primer#2057)
* adds color-scheme style so inputs pick up UA color scheme styles * crops toggle switch knob's shadow inside the toggle switch boundaries * does not stretch FormControl input child to fill parent width unless 'block' prop is passed, and passes missing TextInputWrapper props in the Select component * adds changeset * rm duplicate prop
Configuration menu - View commit details
-
Copy full SHA for f6b91d1 - Browse repository at this point
Copy the full SHA f6b91d1View commit details -
NavList: Add
sx
prop (primer#2077)* Add support for `sx` prop to NavList components * Default sx to empty object * Create happy-brooms-swim.md * Update snapshot
Configuration menu - View commit details
-
Copy full SHA for 50488e8 - Browse repository at this point
Copy the full SHA 50488e8View commit details -
Fix broken inline component links (primer#2082)
* updates Link href paths that link to React components * adds changeset
Configuration menu - View commit details
-
Copy full SHA for 06077e1 - Browse repository at this point
Copy the full SHA 06077e1View commit details -
Fix ActionMenu with IconButton (primer#2084)
* Fix IconButton for ActionMenu * Add test case
Configuration menu - View commit details
-
Copy full SHA for 9c92d10 - Browse repository at this point
Copy the full SHA 9c92d10View commit details -
NavList.Item: Add
as
prop (primer#2076)* Add as prop to NavList.Item * Add test case for react router link with subnav * Use DOM APIs to determine if subnav contains current item * Update snapshots * Remove "not implemented" warnings * Create dry-feet-attack.md * Fix merge issues * Update snapshot
Configuration menu - View commit details
-
Copy full SHA for 46d75c7 - Browse repository at this point
Copy the full SHA 46d75c7View commit details -
Fixes
onRemove
console error coming from token components (primer#2087Configuration menu - View commit details
-
Copy full SHA for 51f0b4a - Browse repository at this point
Copy the full SHA 51f0b4aView commit details -
Fix overflow issues in PageLayout.Content (primer#2075)
* Fix overflow issues in PageLayout.Content * Update PageLayout story * Prettier * Create gentle-countries-rest.md * Fix merge errors * Update src/PageLayout/PageLayout.tsx * Update snapshot Co-authored-by: Dusty Greif <dustin.greif@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bab2bdb - Browse repository at this point
Copy the full SHA bab2bdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ba988a - Browse repository at this point
Copy the full SHA 9ba988aView commit details -
Revert accessible Tooltip + IconButton (primer#2092)
* Revert "Fix ActionMenu with IconButton (primer#2084)" This reverts commit 3204599. * Revert 2069 + 2006 + 2084
Configuration menu - View commit details
-
Copy full SHA for 36afe56 - Browse repository at this point
Copy the full SHA 36afe56View commit details -
Version Packages (primer#2056)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 82ed815 - Browse repository at this point
Copy the full SHA 82ed815View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47d9a25 - Browse repository at this point
Copy the full SHA 47d9a25View commit details -
Fix Dialog example (primer#2083)
* import Dialog v2 instead of old Dialog * Revert "import Dialog v1 instead of old Dialog" This reverts commit 8ac1080. * move the new Dialog to drafts * undeprecate the legacy dialog * Update docs/content/drafts/Dialog.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * update navigation menu * Create funny-hats-sing.md Co-authored-by: Cole Bemis <colebemis@github.com>
Configuration menu - View commit details
-
Copy full SHA for 5bc624b - Browse repository at this point
Copy the full SHA 5bc624bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 454d1d5 - Browse repository at this point
Copy the full SHA 454d1d5View commit details -
Reduce storybook build time in CI to < 2 mins (primer#2093)
* debug-ci-gatsby-build-speed * add storybook as well * remove storybook-addon-html * test: use storybook-addon-html, but disable babel-plugin-open-source * test: remove Pagination component * make room for storybook * try storybook-addon-turbo-build * bring back Pagination * test: optimizationLevel: 2 * debug: give more info during build! * rollback debuging changes * move addon-html back to production only Co-authored-by: Cole Bemis <colebemis@github.com>
Configuration menu - View commit details
-
Copy full SHA for e925621 - Browse repository at this point
Copy the full SHA e925621View commit details -
Adds draft SegmentedControl docs (primer#2081)
* adds a draft for the SegmentedControl component docs * addresses first round of PR feedback * changes 'block' prop name to 'fullWidth * Update docs/content/SegmentedControl.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * Update docs/content/SegmentedControl.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * Update docs/content/SegmentedControl.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * addresses remainder of PR feedback Co-authored-by: Cole Bemis <colebemis@github.com>
Configuration menu - View commit details
-
Copy full SHA for 5841622 - Browse repository at this point
Copy the full SHA 5841622View commit details -
Tests: Add tests for lockfile version (primer#2106)
* Add tests for lockfile version * add resolveJsonModule for typecheck
Configuration menu - View commit details
-
Copy full SHA for 05acb26 - Browse repository at this point
Copy the full SHA 05acb26View commit details -
Allow minor version updates for prod dependencies (primer#2117)
* Allow minor version updates for prod dependencies * Create proud-colts-attend.md
Configuration menu - View commit details
-
Copy full SHA for 715a4a9 - Browse repository at this point
Copy the full SHA 715a4a9View commit details -
chore(deps): bump @primer/octicons-react from 16.1.1 to 17.3.0 (prime…
…r#2119) Bumps [@primer/octicons-react](https://github.com/primer/octicons) from 16.1.1 to 17.3.0. - [Release notes](https://github.com/primer/octicons/releases) - [Changelog](https://github.com/primer/octicons/blob/main/CHANGELOG.md) - [Commits](primer/octicons@v16.1.1...v17.3.0) --- updated-dependencies: - dependency-name: "@primer/octicons-react" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 5eb1b7b - Browse repository at this point
Copy the full SHA 5eb1b7bView commit details -
Export NavList from the main bundle (primer#2112)
* Export ActionListDividerProps * Export NavList from the main bundle * Add NavList link to the nav * Create stale-hounds-notice.md * Add componentId
Configuration menu - View commit details
-
Copy full SHA for ea1b068 - Browse repository at this point
Copy the full SHA ea1b068View commit details -
Fix CI for Node 16.15.1 (primer#2123)
* update package-lock for node 16.15.1 * use Node 14 for docs * Use Node 14 for deploy production
Configuration menu - View commit details
-
Copy full SHA for b4e0812 - Browse repository at this point
Copy the full SHA b4e0812View commit details -
Version Packages (primer#2097)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 857f045 - Browse repository at this point
Copy the full SHA 857f045View commit details -
ADR: Parallel drafts track & plan for deprecated components (primer#1722
) * propose migration plan * Update adr-005.md * Update adr-005.md * move SelectMenu to the first list * Update with parallel track talk * Update adr-005.md * rename back to drafts * Update contributor-docs/adrs/adr-005.md Co-authored-by: Cole Bemis <colebemis@github.com> * Apply suggestions from code review Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: Leslie Cohn-Wein <lesliecdubs@github.com> * Remove component list from ADR Co-authored-by: Mike Perrotti <mperrotti@github.com> Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: Leslie Cohn-Wein <lesliecdubs@github.com>
Configuration menu - View commit details
-
Copy full SHA for fd76066 - Browse repository at this point
Copy the full SHA fd76066View commit details -
ADR 004: Strict props or Composite components (primer#1703)
* Add ADR for children as API * add adrs to eslint ignore list * editing phase 1 * add NewButton examples * lol title * Replace accidental Button usage * change title * add renderChild to the example * Apply suggestions from code review Co-authored-by: Leslie Cohn-Wein <lesliecdubs@github.com> Co-authored-by: Cole Bemis <colebemis@github.com> * Apply suggestions from code review Co-authored-by: Cole Bemis <colebemis@github.com> * Add decision * Update contributor-docs/adrs/adr-004-children-as-api.md * clarify ActionMenu example is from legacy version * removed sidenote because it feels like a tangent Co-authored-by: Leslie Cohn-Wein <lesliecdubs@github.com> Co-authored-by: Cole Bemis <colebemis@github.com>
Configuration menu - View commit details
-
Copy full SHA for ab2b958 - Browse repository at this point
Copy the full SHA ab2b958View commit details -
Fixed an issue with ButtonDanger Not defined. (primer#2128)
Replaced ButtonDanger with Button Component with the props variant="danger" Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Configuration menu - View commit details
-
Copy full SHA for f9f8b5a - Browse repository at this point
Copy the full SHA f9f8b5aView commit details -
Deprecate SideNav in favor of NavList (primer#2120)
* Deprecate SideNav * Create small-donkeys-provide.md
Configuration menu - View commit details
-
Copy full SHA for 977eda7 - Browse repository at this point
Copy the full SHA 977eda7View commit details -
Enforce correct semantics for TabNav (primer#2125)
* Swaps nav and div and adds semantically correct roles * Fix tests, add body div and move sx * Adds changeset * Fixing TabNavProps export Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Configuration menu - View commit details
-
Copy full SHA for b0745de - Browse repository at this point
Copy the full SHA b0745deView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb380f7 - Browse repository at this point
Copy the full SHA fb380f7View commit details -
Navlist passthrough action list group props (primer#2133)
* passthrough actionlist group props to navlist.group * changeset * pass through props * fix pass through block * Update docs/content/NavList.mdx * avoid passing through action list props, but spread additional props to allow aria and data attributes through Co-authored-by: Cole Bemis <colebemis@github.com>
Configuration menu - View commit details
-
Copy full SHA for 13d27e8 - Browse repository at this point
Copy the full SHA 13d27e8View commit details -
Explicitly declare workflow permissions for previews (primer#2137)
* explicitly declare workflow permissions for previews
Configuration menu - View commit details
-
Copy full SHA for 283f575 - Browse repository at this point
Copy the full SHA 283f575View commit details -
Basic SegmentedControl functionality (primer#2108)
* implements basic SegmentedControl functionality * updates file structure * adds SegmentedControl to drafts * adds changeset * fixes TypeScripts issues * revert package-lock.json changes * fixes SegmentedControl tests and updates snapshot * style bug fixes * Update src/SegmentedControl/fixtures.stories.tsx Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> * improve visual design for hover and active states * ARIA updates from Chelsea's feedback * updates tests and snapshots * Ignore *.test.tsx files in build types * Use named export for SegmentedControl This fixes live code examples in the docs * Update package-lock.json * updates lock file * fixes checkExports test for SegmentedControl * design tweak for icon-only segmented control button Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: Cole Bemis <colebemis@github.com>
Configuration menu - View commit details
-
Copy full SHA for ecf9b28 - Browse repository at this point
Copy the full SHA ecf9b28View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5131e7 - Browse repository at this point
Copy the full SHA f5131e7View commit details -
CONTRIBUTING.md: Updating typecheck instructions (primer#2151)
The `typecheck` script was renamed in the past in primer#1960, correcting the contribution docs
Configuration menu - View commit details
-
Copy full SHA for de42e1a - Browse repository at this point
Copy the full SHA de42e1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ac5851 - Browse repository at this point
Copy the full SHA 3ac5851View commit details -
Autocomplete: allow "falsely" input values (primer#2154)
* fix: allow autocomplete input value to be falsely * chore: added changeset * fixes linting error Co-authored-by: Erik Hughes <erik.hughes@outlook.com>
Configuration menu - View commit details
-
Copy full SHA for 86ceeeb - Browse repository at this point
Copy the full SHA 86ceeebView commit details -
fix: checkbox to useIsomorphicLayoutEffect (primer#2155)
Co-authored-by: Erik Hughes <erik.hughes@outlook.com>
Configuration menu - View commit details
-
Copy full SHA for ba49507 - Browse repository at this point
Copy the full SHA ba49507View commit details -
Configuration menu - View commit details
-
Copy full SHA for bba2e4c - Browse repository at this point
Copy the full SHA bba2e4cView commit details -
Add focusZone to TabNav (primer#2139)
* Add focusZone to TabNav * Add aria-selected to tabs * Custom strategy to ensure selected tab is focused on re-entry * Add tests for new TabNav focus management
Configuration menu - View commit details
-
Copy full SHA for d29a5b1 - Browse repository at this point
Copy the full SHA d29a5b1View commit details -
ActionMenu: a11y fixes (batch 1) (primer#2099)
* Don't add aria-expanded=false * remove "Select a" from aria-label * remove tabIndex from AnchoredOverlay * update story to use interactive element * update snapshots * Create anchored-overlay-clever-mails-roll.md * update outdated label in test * Add describedby to milestone story
Configuration menu - View commit details
-
Copy full SHA for bc31e5d - Browse repository at this point
Copy the full SHA bc31e5dView commit details -
ActionMenu: Replace typeahead with mnemonics (primer#2105)
* Replace typeahead with mnemonics * add aria-keyshortcuts as part of useMnemonics * Create gold-falcons-shake.md * support user configured aria-keyshortcuts * delete unused useTypeaheadFocus
Configuration menu - View commit details
-
Copy full SHA for ab4d40c - Browse repository at this point
Copy the full SHA ab4d40cView commit details -
Selected tab doesn't need to be <a> tag (primer#2158)
* Selected tab doesn't need to be a tag * Updates tests for new code and updates snapshot
Configuration menu - View commit details
-
Copy full SHA for 8506cfc - Browse repository at this point
Copy the full SHA 8506cfcView commit details -
AnchoredOverlay: Keep tabIndex for renderAnchor (primer#2159)
* Revert "remove tabIndex from AnchoredOverlay" This reverts commit e7f2d03. * remove change from changelog as well * update matching snapshots
Configuration menu - View commit details
-
Copy full SHA for 738d587 - Browse repository at this point
Copy the full SHA 738d587View commit details -
Version Packages (primer#2131)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 02767f0 - Browse repository at this point
Copy the full SHA 02767f0View commit details -
SplitPageLayout API (primer#2144)
* Draft SplitPageLayout API docs * Update docs/content/SplitPageLayout.mdx Co-authored-by: Vinicius Depizzol <vdepizzol@gmail.com> * Update docs/content/SplitPageLayout.mdx * visible -> hidden prop Co-authored-by: Vinicius Depizzol <vdepizzol@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0d364bb - Browse repository at this point
Copy the full SHA 0d364bbView commit details -
Convert commonjs code to esm during build (primer#2150)
* Build theme-preval to esm * Use default export for theme-preval * Create sweet-elephants-end.md * Update theme-preval snapshot
Configuration menu - View commit details
-
Copy full SHA for 1d82c16 - Browse repository at this point
Copy the full SHA 1d82c16View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2685ed - Browse repository at this point
Copy the full SHA e2685edView commit details -
Correct and improve Storybook and docs for form controls (primer#2143)
* updates checkbox props tables, storybook stories, and storybook controls * updates Radio props table, Storybook stories, and Storybook controls * updates FormControl Storybook stories, and Storybook controls * updates TextInput and TextInputWithWrapper props tables, Storybook stories, and Storybook controls * updates Select stories * fixes more issues with Select stories and prop docs * updates Textarea prop tables, Storybook stories, and Storybook controls * updates CheckboxGroup and RadioGroup Storybook stories, and Storybook controls * updates Autocomplete Storybook stories, and Storybook controls * fixes 'size' control in TextInput stories * fixes a11y issues with Autocomplete examples * updates input stories to use the FormControl component and controls, and updates sidebar to reflect that relationship * updates tests * adds changeset * fix linting issue * updates after merging from main * excludes story-helpers.tsx from build * fixes regression in CheckboxGroup and RadioGroup fixture stories
Configuration menu - View commit details
-
Copy full SHA for 3e8ab89 - Browse repository at this point
Copy the full SHA 3e8ab89View commit details -
Bump primer primitives to latest
7.8.4
(primer#2180)* update version of primer primitives * update preval stamp * changeset * update snapshot
Configuration menu - View commit details
-
Copy full SHA for bcee2e6 - Browse repository at this point
Copy the full SHA bcee2e6View commit details -
Improves keyboard navigation for the SegmentedControl (primer#2145)
* implements keyboard navigation strategy for the SegmentedControl suggested by the a11y team, and warns component users if the control does not have a label * adds changeset * crappy fix for bug where useFocusZone breaks after selecting a button * corrects typo in test name * consolidates button focus test, and adds comment to focusInStrategy test * remove getNextFocusable by tweaking focusInStrategy Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Configuration menu - View commit details
-
Copy full SHA for 1d263e9 - Browse repository at this point
Copy the full SHA 1d263e9View commit details -
Version Packages (primer#2161)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 41533f2 - Browse repository at this point
Copy the full SHA 41533f2View commit details -
Updated StateLabel to include
issueClosedNotPlanned
and fix `issueC……losed` colour (primer#2171) * Updated StateLabel * Add changeset * Update test * Update the test suites
Configuration menu - View commit details
-
Copy full SHA for b403fed - Browse repository at this point
Copy the full SHA b403fedView commit details -
Fix broken focus outline on the Select component (primer#2173)
* fixes broken focus outline on the Select component * fixes linting issue * adds changeset
Configuration menu - View commit details
-
Copy full SHA for e2f385a - Browse repository at this point
Copy the full SHA e2f385aView commit details -
SegmentedControl variant prop (primer#2164)
* renders a tooltip for icon-only segmented control buttons * implements responsive variant prop * adds tests * minor story tweaks * refactor useMatchMedia * adds useMatchMedia tests, fixes useMatchMedia bugs, updates SegmentedControl tests * removes aria attributes from Storybook controls * rm irrelevant 'TODO' comments * adds changeset * adds helpful comments * fixes button font-size in Safari * updates snapshots * addresses PR feedback * Update docs/content/SegmentedControl.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * Update docs/content/SegmentedControl.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * Update .changeset/pretty-students-judge.md Co-authored-by: Josep Martins <jsp.mrtns@gmail.com> * bumps @primer/primitives to version with segmented control variables * corrects storybook knobs to match current API * rm 'wide' key from 'variant' prop in props table * fix bad merge in SegmentedControl * adds more context to a11y issues with the tooltip implementation * adds changeset Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: Josep Martins <jsp.mrtns@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c7903d7 - Browse repository at this point
Copy the full SHA c7903d7View commit details -
Use SegmentedControl component primitives (primer#2186)
* bumps @primer/primitives and uses SegmentedControl component tokens * revert comment change in SegmentedControlIconButton * adds changeset * update themePreval snap with primitives@7.9.0
Configuration menu - View commit details
-
Copy full SHA for 364a5ec - Browse repository at this point
Copy the full SHA 364a5ecView commit details -
PageLayout: Implement responsive
hidden
prop (primer#2174)* Implement responsive hidden prop * Write tests for useResponsiveValue * Document hidden prop * Update viewport range variables * Add hidden prop to header/footer/content * Update PageLayout tests * Create empty-garlics-clean.md * Fix lint errors
Configuration menu - View commit details
-
Copy full SHA for 00027d0 - Browse repository at this point
Copy the full SHA 00027d0View commit details -
Button should respect polymorphic as prop (primer#2166)
* update button to respect polymorphic as prop * update docs * update docs * fix doc * changeset * fix by removing sc as propr types * Add back link buttons stories using basic button Co-authored-by: Pavithra Kodmad <pksjce@github.com>
Configuration menu - View commit details
-
Copy full SHA for e906f9f - Browse repository at this point
Copy the full SHA e906f9fView commit details -
[passion week] Interaction tests with storybook's play function (prim…
…er#2172) * Add storybook play function for autocomplete * Add github workflow * Must run on pull-request and push to main * Package.lock revert * update workflow * configure static directories * Build storybooks correctly * A more complete autocomplete test * Fix up packge lock? * Fix up packge lock? * Add some documentation * Fix up autocomplete tests by adding data-testid
Configuration menu - View commit details
-
Copy full SHA for 959e83b - Browse repository at this point
Copy the full SHA 959e83bView commit details -
Codemod for react 18 children types (primer#2196)
* run react 18 types codemod * run prettier * changeset
Configuration menu - View commit details
-
Copy full SHA for 80bef41 - Browse repository at this point
Copy the full SHA 80bef41View commit details -
Upgrade
user-event
to v14 (primer#2190)* Upgrade `userEvent` to v14 * Fix Autocomplete tests Co-authored-by: Cole Bemis <colebemis@github.com>
Configuration menu - View commit details
-
Copy full SHA for 12bdb53 - Browse repository at this point
Copy the full SHA 12bdb53View commit details -
PageLayout: Update
divider
prop responsive API (primer#2198)* Deprecate dividerWhenNarrow in favor of responsive values * Update PageLayout docs * Create spotty-parents-cheat.md * Update spotty-parents-cheat.md * Update snapshots
Configuration menu - View commit details
-
Copy full SHA for 8c2beaa - Browse repository at this point
Copy the full SHA 8c2beaaView commit details -
docs: NavList example with next/link's URL object (primer#2203)
Adding another use-case in the NavList's NextJS example
Configuration menu - View commit details
-
Copy full SHA for ed11f24 - Browse repository at this point
Copy the full SHA ed11f24View commit details -
PageLayout: Update
position
responsive prop API (primer#2199)* Update position prop API * Update snapshots * Update docs * Create fair-tips-travel.md
Configuration menu - View commit details
-
Copy full SHA for a7ff271 - Browse repository at this point
Copy the full SHA a7ff271View commit details -
ActionMenu: Remove focus trap + Fix initial focus (primer#2024)
* Revert "Revert "ActionMenu: Remove focus trap (primer#1984)" (primer#2023)" This reverts commit 866abc0. * prevent scroll when moving from anchor to menu * Add shortcut example from memex * progress! * make refs required * onclick should not interfere with keyboard * default to first item if anchor is not used * use userEvent instead of fireEvent for test to get full event * remedy merge * ignore containerRef for initial focus * update changeset to include initial focus on click * migrate to user-event@14 Co-authored-by: Cole Bemis <colebemis@github.com>
Configuration menu - View commit details
-
Copy full SHA for 2daac91 - Browse repository at this point
Copy the full SHA 2daac91View commit details -
Default ConfirmationDialog to focusing
cancel
when the confirmation…… is a dangerous one (primer#2185) * allow configuration of the initial focus in a confirmation dialog * changeset * explicitly set the autoFocus when danger to cancel * intermediate value Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Configuration menu - View commit details
-
Copy full SHA for 201ffc9 - Browse repository at this point
Copy the full SHA 201ffc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2681253 - Browse repository at this point
Copy the full SHA 2681253View commit details
Commits on Aug 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8bf391b - Browse repository at this point
Copy the full SHA 8bf391bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8f6f25 - Browse repository at this point
Copy the full SHA e8f6f25View commit details
Commits on Aug 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ba88741 - Browse repository at this point
Copy the full SHA ba88741View commit details