Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip commonjs transform for storybook #2177

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Skip commonjs transform for storybook #2177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ module.exports = {
plugins: [
...(process.env.BABEL_MODULE === 'commonjs'
? ['@babel/plugin-transform-modules-commonjs']
: process.env.STORYBOOK
? []
: [
'transform-commonjs' // theme-preval is commonjs and needs to be transformed to esm
]),
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"build": "./script/build",
"start": "concurrently npm:start:*",
"start:docs": "cd docs && npm run develop",
"start:storybook": "start-storybook -p 6006",
"start:storybook": "STORYBOOK=true start-storybook -p 6006",
"build:storybook": "script/build-storybook",
"build:docs": "script/build-docs",
"build:docs:preview": "script/build-docs preview",
Expand Down
2 changes: 1 addition & 1 deletion script/build-storybook
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ else
fi

# Build storybook inside docs
./node_modules/.bin/build-storybook -o docs/public/storybook -s docs/public/static
STORYBOOK=true ./node_modules/.bin/build-storybook -o docs/public/storybook -s docs/public/static

# Remove manager-head after build to not interfere with dev builds
rm .storybook/manager-head.html