Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend theme provider props to accept children #2195

Closed

Conversation

aspnxdd
Copy link

@aspnxdd aspnxdd commented Jul 27, 2022

Added a functionality to extend the ThemeProviderProps type to accept children (React.ReactNode).

Closes #2194

Screenshots

image

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@aspnxdd aspnxdd requested review from a team and siddharthkp July 27, 2022 13:17
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2022

⚠️ No Changeset found

Latest commit: 29938eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp
Copy link
Member

Hi! Thanks for taking the time!

I think we need to do that in all our components, not just ThemeProvider, do you think #2196 is a superset of this PR?

@siddharthkp siddharthkp added react 💓collab a vibrant hub of collaboration and removed 💓collab a vibrant hub of collaboration labels Jul 27, 2022
@aspnxdd
Copy link
Author

aspnxdd commented Jul 27, 2022

Hi! Thanks for taking the time!

I think we need to do that in all our components, not just ThemeProvider, do you think #2196 is a superset of this PR?

Hi. Yes, I think it is a superset of this PR.

@colebemis
Copy link
Contributor

colebemis commented Jul 27, 2022

Thanks, @aspnxdd! Closing this in favor of #2196.

@colebemis colebemis closed this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThemeProviderProps does not accept children.
3 participants