Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export new UnderlineNav in the main bundle and move the older one to the deprecated bundle - Major release #2728

Closed
wants to merge 12 commits into from

Conversation

broccolinisoup
Copy link
Member

Describe your changes here.

Closes # (type the issue number after # if applicable; otherwise remove this line)

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@broccolinisoup broccolinisoup added the major release breaking changes label Dec 29, 2022
@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022

🦋 Changeset detected

Latest commit: 96d86fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 88.55 KB (-0.45% 🔽)
dist/browser.umd.js 89.2 KB (-0.41% 🔽)

@broccolinisoup broccolinisoup changed the title Export new UnderlineNav in main and deprecate the older one Export new UnderlineNav in the main bundle and move the older one to the deprecated bundle Dec 29, 2022
@broccolinisoup broccolinisoup temporarily deployed to github-pages December 29, 2022 06:02 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 December 29, 2022 06:03 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages December 30, 2022 02:23 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 December 30, 2022 02:24 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages December 30, 2022 02:35 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 December 30, 2022 02:35 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages December 30, 2022 02:41 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 December 30, 2022 02:41 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages December 30, 2022 02:47 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 December 30, 2022 02:47 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages December 30, 2022 03:02 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 December 30, 2022 03:03 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages December 30, 2022 03:11 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 December 30, 2022 03:11 Inactive
@broccolinisoup broccolinisoup removed the major release breaking changes label Dec 30, 2022
@broccolinisoup broccolinisoup temporarily deployed to github-pages December 30, 2022 03:48 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 December 30, 2022 03:48 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages January 3, 2023 04:22 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 January 3, 2023 04:22 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages January 3, 2023 04:46 — with GitHub Actions Inactive
@primer primer bot temporarily deployed to github-pages January 27, 2023 05:47 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 January 27, 2023 05:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 January 27, 2023 05:48 Inactive
@broccolinisoup
Copy link
Member Author

broccolinisoup commented Jan 27, 2023

Hey @broccolinisoup! I've been trying to make sure all the branches are up-to-date with the new vrt workflow. I wanted to ask if you have any free time this week to update the conflicts on this PR?

Thanks @joshblack! I updated the branch and resolved all conflicts. The VRT and AAT checks are failing though and the Update snapshots label didn't work either. I am really not sure what is going on 😢

@joshblack joshblack temporarily deployed to github-pages January 27, 2023 21:13 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2728 January 27, 2023 21:13 Inactive
@joshblack
Copy link
Member

Hey @broccolinisoup! 👋

I think when the id of the stories change (like removing drafts) the tests themselves will need to be changed. I pushed up a commit that I think should tackle the new paths 🤞

@broccolinisoup
Copy link
Member Author

Hey @broccolinisoup! 👋

I think when the id of the stories change (like removing drafts) the tests themselves will need to be changed. I pushed up a commit that I think should tackle the new paths 🤞

Thanks so much @joshblack ! It is very interesting - I thought I did that step. I even documented it on the depreciation component docs but apparently I failed to apply that step on my own PR lol Thanks a bunch!

@broccolinisoup broccolinisoup changed the title Export new UnderlineNav in the main bundle and move the older one to the deprecated bundle Export new UnderlineNav in the main bundle and move the older one to the deprecated bundle - Major release Jan 29, 2023
@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@broccolinisoup
Copy link
Member Author

Closing this in favor of #3260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants