Skip to content

Conversation

@Zenulous
Copy link
Contributor

When working with Primer/React for a project I noticed that nowadays there are far more color schemes on https://primer.style/react/theme-reference than what is denoted in the docs, e.g. dark_high_contrast. It might be better to remove the explicit number of available color schemes from the docs (unless I am mistaken by what a color scheme denotes).

Merge checklist

  • [ x ] Added/updated tests
  • [ x ] Added/updated documentation
  • [ x ] Tested in Chrome
  • [ x ] Tested in Firefox
  • [ x ] Tested in Safari
  • [ x ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@Zenulous Zenulous requested review from a team and JoshBowdenConcepts January 30, 2023 09:55
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2023

⚠️ No Changeset found

Latest commit: bee0653

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! 🙌

@joshblack joshblack added the skip changeset This change does not need a changelog label Jan 30, 2023
@joshblack joshblack enabled auto-merge (squash) January 30, 2023 19:52
@joshblack joshblack merged commit 85e23c4 into primer:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants