-
Notifications
You must be signed in to change notification settings - Fork 646
refactor(Flash): move files to folder, add e2e tests and stories #2883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
size-limit report 📦
|
src/Flash/Flash.stories.tsx
Outdated
| @@ -0,0 +1,38 @@ | |||
| import React from 'react' | |||
| import {Meta, Story} from '@storybook/react' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use MetaComponent and StoryComponent here? storybookjs/storybook#16650 (comment)
Or was there any reason we used this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@broccolinisoup great catch, I've just been using existing templates but I think you're dead-on that we should be using MetaComponent and StoryComponent.
cc @langermank just a heads up for above 👆, it also seems to address props like as and forwardedAs causing issues on argTypes 🥳
Parent issue: https://github.com/github/primer/issues/1488
Add storybook stories for
FlashChecklist