Skip to content

Conversation

@joshblack
Copy link
Member

Parent issue: https://github.com/github/primer/issues/1488

Add storybook stories for Flash

Checklist

  • Ensure your chosen component has a component directory in the src directory
  • Ensure the component has a root story file in the component directory
  • Ensure that the root story file exports a Default story
  • (Optional) Create a Playground story
  • Move all other stories for the component into a .features.stories.tsx file
  • Opt the component into storybook tests
  • (Optional) Create visual regression tests for the component

@joshblack joshblack requested review from a team and JoshBowdenConcepts February 8, 2023 21:37
@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2023

⚠️ No Changeset found

Latest commit: eb984ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added skip changeset This change does not need a changelog update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 89.68 KB (-0.01% 🔽)
dist/browser.umd.js 90.24 KB (-0.01% 🔽)

@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 8, 2023
@github-actions github-actions bot temporarily deployed to storybook-preview-2883 February 8, 2023 22:05 Inactive
@joshblack joshblack temporarily deployed to github-pages February 8, 2023 22:08 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2883 February 8, 2023 22:09 Inactive
@@ -0,0 +1,38 @@
import React from 'react'
import {Meta, Story} from '@storybook/react'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use MetaComponent and StoryComponent here? storybookjs/storybook#16650 (comment)
Or was there any reason we used this version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@broccolinisoup great catch, I've just been using existing templates but I think you're dead-on that we should be using MetaComponent and StoryComponent.

cc @langermank just a heads up for above 👆, it also seems to address props like as and forwardedAs causing issues on argTypes 🥳

@joshblack joshblack temporarily deployed to github-pages February 9, 2023 19:04 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2883 February 9, 2023 19:04 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2883 February 9, 2023 19:05 Inactive
@joshblack joshblack added this pull request to the merge queue Feb 9, 2023
@joshblack joshblack removed this pull request from the merge queue due to the queue being cleared Feb 9, 2023
@joshblack joshblack enabled auto-merge February 10, 2023 16:36
@github-actions github-actions bot temporarily deployed to storybook-preview-2883 February 10, 2023 16:41 Inactive
@joshblack joshblack temporarily deployed to github-pages February 10, 2023 16:41 — with GitHub Actions Inactive
@joshblack joshblack added this pull request to the merge queue Feb 10, 2023
Merged via the queue into main with commit 1f31c3e Feb 10, 2023
@joshblack joshblack deleted the docs/add-flash-stories branch February 10, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants