Skip to content

Docs: use sx instead of system props in Box examples #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2023
Merged

Docs: use sx instead of system props in Box examples #2886

merged 2 commits into from
Feb 15, 2023

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Feb 9, 2023

@siddharthkp siddharthkp added the docs Documentation label Feb 9, 2023
@siddharthkp siddharthkp self-assigned this Feb 9, 2023
@siddharthkp siddharthkp requested a review from a team February 9, 2023 11:28
@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 01d5d70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp mentioned this pull request Feb 9, 2023
Closed
broccolinisoup
broccolinisoup approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ✨ Thanks for doing this Sid!

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Feb 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 89.74 KB (0%)
dist/browser.umd.js 90.28 KB (0%)

@siddharthkp siddharthkp temporarily deployed to github-pages February 15, 2023 17:31 — with GitHub Actions Inactive
@siddharthkp siddharthkp added this pull request to the merge queue Feb 15, 2023
Merged via the queue into main with commit 7c76b4a Feb 15, 2023
@siddharthkp siddharthkp deleted the docs-remove-box-system-props branch February 15, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@joshblack joshblack joshblack approved these changes

Assignees

@siddharthkp siddharthkp

Labels

docs Documentation react skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Primer React Box component examples appear out of date

4 participants

@siddharthkp @broccolinisoup @joshblack