Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionList: Fix icon and description hover color for danger variant #3045

Closed
wants to merge 11 commits into from
Closed

ActionList: Fix icon and description hover color for danger variant #3045

wants to merge 11 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Mar 16, 2023 •
edited
Loading

@changeset-bot

This comment was marked as outdated.

Sign in to view
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Mar 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 95.19 KB (+0.06% 🔺)
dist/browser.umd.js 95.76 KB (+0.05% 🔺)

@siddharthkp siddharthkp temporarily deployed to github-pages March 16, 2023 17:28 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3045 March 16, 2023 17:28 Inactive
@siddharthkp siddharthkp changed the title ActionList stories: Add variant for danger in all combinations ActionList: Fix icon and description color for danger Mar 20, 2023
@siddharthkp siddharthkp changed the title ActionList: Fix icon and description color for danger ActionList: Fix icon and description hover color for danger variant Mar 20, 2023
@siddharthkp siddharthkp self-assigned this Mar 20, 2023
@siddharthkp siddharthkp removed the skip changeset This change does not need a changelog label Mar 20, 2023
@github-actions github-actions bot temporarily deployed to storybook-preview-3045 March 20, 2023 13:07 Inactive
@siddharthkp siddharthkp mentioned this pull request Mar 20, 2023
Closed
@siddharthkp siddharthkp marked this pull request as ready for review March 20, 2023 13:08
@siddharthkp siddharthkp requested review from a team and JoshBowdenConcepts March 20, 2023 13:08
@github-actions github-actions bot temporarily deployed to storybook-preview-3045 March 20, 2023 13:12 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages March 20, 2023 13:12 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3045 March 20, 2023 13:12 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages March 20, 2023 13:26 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3045 March 20, 2023 13:27 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages March 20, 2023 15:08 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3045 March 20, 2023 15:09 Inactive
langermank
langermank approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@siddharthkp siddharthkp requested review from joshblack and removed request for JoshBowdenConcepts March 20, 2023 15:43
joshblack
joshblack approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just left a comment for the @aat stuff, should be good to go after updating the snapshots 👍

e2e/components/ActionList.test.ts Outdated Show resolved Hide resolved
@siddharthkp @joshblack
Update e2e/components/ActionList.test.ts
b0ad64f 
Co-authored-by: Josh Black <joshblack@github.com>
@siddharthkp siddharthkp temporarily deployed to github-pages March 21, 2023 16:06 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3045 March 21, 2023 16:06 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages March 29, 2023 15:10 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3045 March 29, 2023 16:16 Inactive
@primer primer bot temporarily deployed to github-pages April 6, 2023 12:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3045 April 6, 2023 12:20 Inactive
@langermank
Copy link
Contributor

@siddharthkp what's the latest on this? Is it good to merge?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 9, 2023
@siddharthkp
Copy link
Member Author

Replaced by #3505

@siddharthkp siddharthkp deleted the repro-actionlist-danger branch December 7, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@joshblack joshblack joshblack approved these changes

Assignees

@siddharthkp siddharthkp

Labels
react Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddharthkp @langermank @joshblack