Refactor MarkdownViewer to make it SSR-friendly #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8b8b825 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
colebemis
requested review from
iansan5653 and
joshblack
and removed request for
langermank
iansan5653
reviewed
Apr 21, 2023
iansan5653
reviewed
Apr 21, 2023
…b.com:primer/react into markdownviewer-ssr
joshblack
approved these changes
Apr 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Apr 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MarkdownViewercannot be rendered on the serverSolution
This PR refactors
MarkdownViewto be SSR-friendly:dangerouslySetInnerHTMLinstead of settinginnerHTMLinside an effect.useLayoutEffectwithuseEffect.useLayoutEffectthrows an error on server-side.Addresses https://github.com/github/primer/issues/2090