Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minWidth prop to PageLayout.Pane #3229

Merged
merged 5 commits into from
May 1, 2023
Merged

Add minWidth prop to PageLayout.Pane #3229

merged 5 commits into from
May 1, 2023

Conversation

colebemis
Copy link
Contributor

Closes #3116

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

🦋 Changeset detected

Latest commit: 86dad15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 121.18 KB (+0.01% 🔺)
dist/browser.umd.js 121.48 KB (+0.01% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-3229 April 26, 2023 19:06 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3229 April 26, 2023 19:07 Inactive
@colebemis colebemis marked this pull request as ready for review April 26, 2023 19:07
@colebemis colebemis requested review from a team and siddharthkp April 26, 2023 19:07
@github-actions github-actions bot temporarily deployed to storybook-preview-3229 April 26, 2023 19:09 Inactive
@colebemis colebemis added this pull request to the merge queue Apr 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 27, 2023
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshblack joshblack added this pull request to the merge queue May 1, 2023
Merged via the queue into main with commit c0cbdd0 May 1, 2023
@joshblack joshblack deleted the pagelayout-min-width branch May 1, 2023 15:02
This was referenced May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SplitPageLayout.Pane minWidth is hardcoded
3 participants