Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Accessibility engineering review for Link component." #3459

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Jun 29, 2023

Reverts #3317

TL;DR
This PR introduces breaking changes to github/github

Issues discovered:

  1. This PR removes the as prop from Link component however there are currently 15 usages at github/github that has as prop (error log at dotcom for reference)
  2. This PR introduces an optional to prop as a string type on the ActionList.LinkItem component. This does look a minor change however it is breaking existing usages. The current ActionList.LinkItem component and NavList (it uses ActionList.LinkItem in the background) pass the given props through and because to is a special prop name for react router, folks already have usages with this to prop. Limiting this prop to be string is breaking existing usages. (error log at dotcom for reference)

@broccolinisoup broccolinisoup requested review from a team and langermank June 29, 2023 04:30
@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2023

⚠️ No Changeset found

Latest commit: 5589c62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 101.82 KB (-0.13% 🔽)
dist/browser.umd.js 102.36 KB (-0.14% 🔽)

@broccolinisoup broccolinisoup added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit f577190 Jun 30, 2023
@broccolinisoup broccolinisoup deleted the revert-3317-link-a11y-review branch June 30, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants