Revert "Accessibility engineering review for Link component." #3459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3317
TL;DR
This PR introduces breaking changes to github/github
Issues discovered:
as
prop fromLink
component however there are currently 15 usages at github/github that hasas
prop (error log at dotcom for reference)to
prop as astring
type on theActionList.LinkItem
component. This does look a minor change however it is breaking existing usages. The currentActionList.LinkItem
component andNavList
(it usesActionList.LinkItem
in the background) pass the given props through and becauseto
is a special prop name for react router, folks already have usages with thisto
prop. Limiting this prop to bestring
is breaking existing usages. (error log at dotcom for reference)